aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Gortmaker <paul.gortmaker@windriver.com>2015-05-09 20:27:37 -0400
committerThomas Gleixner <tglx@linutronix.de>2015-05-19 05:23:38 -0400
commitea6cd25058f39ac69623efdcbd94a7fc7d4d13f0 (patch)
tree73b36cd623de6408f6aa21a50928bf5acd08745d
parent7cb685982157567dcc55eb92d1c38d237465203b (diff)
x86: Rename eisa_set_level_irq to elcr_set_level_irq
This routine has been around for over a decade, but with EISA being dead and abandoned for about twice that long, the name can be kind of confusing. The function is going at the PIC Edge/Level Configuration Registers (ELCR), so rename it as such and mentally decouple it from the long since dead EISA bus. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org> Acked-by: Pavel Machek <pavel@ucw.cz> Cc: Rafael J. Wysocki <rjw@rjwysocki.net> Cc: Len Brown <len.brown@intel.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: x86@kernel.org Link: http://lkml.kernel.org/r/1431217657-934-1-git-send-email-paul.gortmaker@windriver.com Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r--arch/x86/include/asm/hw_irq.h3
-rw-r--r--arch/x86/kernel/acpi/boot.c2
-rw-r--r--arch/x86/pci/irq.c13
3 files changed, 9 insertions, 9 deletions
diff --git a/arch/x86/include/asm/hw_irq.h b/arch/x86/include/asm/hw_irq.h
index 9472c9aff26d..9ec5d37d8da3 100644
--- a/arch/x86/include/asm/hw_irq.h
+++ b/arch/x86/include/asm/hw_irq.h
@@ -157,8 +157,7 @@ static inline void unlock_vector_lock(void) {}
157extern atomic_t irq_err_count; 157extern atomic_t irq_err_count;
158extern atomic_t irq_mis_count; 158extern atomic_t irq_mis_count;
159 159
160/* EISA */ 160extern void elcr_set_level_irq(unsigned int irq);
161extern void eisa_set_level_irq(unsigned int irq);
162 161
163/* SMP */ 162/* SMP */
164extern __visible void smp_apic_timer_interrupt(struct pt_regs *); 163extern __visible void smp_apic_timer_interrupt(struct pt_regs *);
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 271293ad89d7..e49ee24da85e 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -608,7 +608,7 @@ static int acpi_register_gsi_pic(struct device *dev, u32 gsi,
608 * Make sure all (legacy) PCI IRQs are set as level-triggered. 608 * Make sure all (legacy) PCI IRQs are set as level-triggered.
609 */ 609 */
610 if (trigger == ACPI_LEVEL_SENSITIVE) 610 if (trigger == ACPI_LEVEL_SENSITIVE)
611 eisa_set_level_irq(gsi); 611 elcr_set_level_irq(gsi);
612#endif 612#endif
613 613
614 return gsi; 614 return gsi;
diff --git a/arch/x86/pci/irq.c b/arch/x86/pci/irq.c
index 5dc6ca5e1741..9bd115484745 100644
--- a/arch/x86/pci/irq.c
+++ b/arch/x86/pci/irq.c
@@ -146,19 +146,20 @@ static void __init pirq_peer_trick(void)
146 146
147/* 147/*
148 * Code for querying and setting of IRQ routes on various interrupt routers. 148 * Code for querying and setting of IRQ routes on various interrupt routers.
149 * PIC Edge/Level Control Registers (ELCR) 0x4d0 & 0x4d1.
149 */ 150 */
150 151
151void eisa_set_level_irq(unsigned int irq) 152void elcr_set_level_irq(unsigned int irq)
152{ 153{
153 unsigned char mask = 1 << (irq & 7); 154 unsigned char mask = 1 << (irq & 7);
154 unsigned int port = 0x4d0 + (irq >> 3); 155 unsigned int port = 0x4d0 + (irq >> 3);
155 unsigned char val; 156 unsigned char val;
156 static u16 eisa_irq_mask; 157 static u16 elcr_irq_mask;
157 158
158 if (irq >= 16 || (1 << irq) & eisa_irq_mask) 159 if (irq >= 16 || (1 << irq) & elcr_irq_mask)
159 return; 160 return;
160 161
161 eisa_irq_mask |= (1 << irq); 162 elcr_irq_mask |= (1 << irq);
162 printk(KERN_DEBUG "PCI: setting IRQ %u as level-triggered\n", irq); 163 printk(KERN_DEBUG "PCI: setting IRQ %u as level-triggered\n", irq);
163 val = inb(port); 164 val = inb(port);
164 if (!(val & mask)) { 165 if (!(val & mask)) {
@@ -965,11 +966,11 @@ static int pcibios_lookup_irq(struct pci_dev *dev, int assign)
965 } else if (r->get && (irq = r->get(pirq_router_dev, dev, pirq)) && \ 966 } else if (r->get && (irq = r->get(pirq_router_dev, dev, pirq)) && \
966 ((!(pci_probe & PCI_USE_PIRQ_MASK)) || ((1 << irq) & mask))) { 967 ((!(pci_probe & PCI_USE_PIRQ_MASK)) || ((1 << irq) & mask))) {
967 msg = "found"; 968 msg = "found";
968 eisa_set_level_irq(irq); 969 elcr_set_level_irq(irq);
969 } else if (newirq && r->set && 970 } else if (newirq && r->set &&
970 (dev->class >> 8) != PCI_CLASS_DISPLAY_VGA) { 971 (dev->class >> 8) != PCI_CLASS_DISPLAY_VGA) {
971 if (r->set(pirq_router_dev, dev, pirq, newirq)) { 972 if (r->set(pirq_router_dev, dev, pirq, newirq)) {
972 eisa_set_level_irq(newirq); 973 elcr_set_level_irq(newirq);
973 msg = "assigned"; 974 msg = "assigned";
974 irq = newirq; 975 irq = newirq;
975 } 976 }