aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRussell King <rmk+kernel@arm.linux.org.uk>2015-06-16 18:06:50 -0400
committerThomas Gleixner <tglx@linutronix.de>2015-06-18 08:03:08 -0400
commite88d251d6a4fb719f9f667a397cf5d755121e551 (patch)
tree3b72e3a158d86aaa5faa84418fa000f52c3d143a
parenta44735f421b44724d52117358573f8ded473ecc7 (diff)
gpio: gpio-tegra: Fix race in installing chained IRQ handler
Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to irq_set_chained_handler_and_data(). Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Cc: Alexandre Courbot <gnurou@gmail.com> Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com> Cc: Jason Cooper <jason@lakedaemon.net> Cc: Lee Jones <lee.jones@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/E1Z4z0M-0002Sl-Ti@rmk-PC.arm.linux.org.uk Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r--drivers/gpio/gpio-tegra.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index 1741981d53c8..56dcc8ed98de 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -515,8 +515,8 @@ static int tegra_gpio_probe(struct platform_device *pdev)
515 for (i = 0; i < tegra_gpio_bank_count; i++) { 515 for (i = 0; i < tegra_gpio_bank_count; i++) {
516 bank = &tegra_gpio_banks[i]; 516 bank = &tegra_gpio_banks[i];
517 517
518 irq_set_chained_handler(bank->irq, tegra_gpio_irq_handler); 518 irq_set_chained_handler_and_data(bank->irq,
519 irq_set_handler_data(bank->irq, bank); 519 tegra_gpio_irq_handler, bank);
520 520
521 for (j = 0; j < 4; j++) 521 for (j = 0; j < 4; j++)
522 spin_lock_init(&bank->lvl_lock[j]); 522 spin_lock_init(&bank->lvl_lock[j]);