aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBorislav Petkov <bp@suse.de>2015-05-16 12:17:59 -0400
committerIngo Molnar <mingo@kernel.org>2015-05-17 01:57:53 -0400
commite839004b49c571e20006092cbe9da8f2c95d2e71 (patch)
tree20bebf2e1a2d65b79e870c39d81bd2a569626d67
parent75d95d84888cbd0024eb62ca7e72b3f7fe67dbdd (diff)
x86/asm/head*.S: Change global labels to local
Make the disassembly look less confusing: -- head_64.o.before.asm ++ head_64.o.after.asm 0000000000000120 <early_idt_handler>: 120: fc cld 121: 83 3c 24 02 cmpl $0x2,(%rsp) - 125: 0f 84 9d 00 00 00 je 1c8 <is_nmi> + 125: 0f 84 9d 00 00 00 je 1c8 <early_idt_handler+0xa8> 12b: 83 3d 00 00 00 00 02 cmpl $0x2,0x0(%rip) # 132 <early_idt_handler+0x12> 132: 74 7e je 1b2 <early_idt_handler+0x92> 134: ff 05 00 00 00 00 incl 0x0(%rip) # 13a <early_idt_handler+0x1a> @@ -1198,9 +1198,7 @@ Disassembly of section .init.text: 1bf: 5a pop %rdx 1c0: 59 pop %rcx 1c1: 58 pop %rax - 1c2: ff 0d 00 00 00 00 decl 0x0(%rip) # 1c8 <is_nmi> - -00000000000001c8 <is_nmi>: + 1c2: ff 0d 00 00 00 00 decl 0x0(%rip) # 1c8 <early_idt_handler+0xa8> 1c8: 48 83 c4 10 add $0x10,%rsp 1cc: 48 cf iretq -- head_32.o.before.asm ++ head_32.o.after.asm 0000016c <early_idt_handler>: 16c: fc cld 16d: 83 3c 24 02 cmpl $0x2,(%esp) - 171: 74 73 je 1e6 <is_nmi> + 171: 74 73 je 1e6 <ex_entry+0xc> 173: 36 83 3d 00 00 00 00 cmpl $0x2,%ss:0x0 17a: 02 17b: 74 5a je 1d7 <hlt_loop> @@ -483,8 +483,6 @@ Disassembly of section .init.text: 1dd: 59 pop %ecx 1de: 58 pop %eax 1df: 36 ff 0d 00 00 00 00 decl %ss:0x0 - -000001e6 <is_nmi>: 1e6: 83 c4 08 add $0x8,%esp 1e9: cf iret 1ea: 66 90 xchg %ax,%ax No functionality change. Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@linux.intel.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/1431793079-11153-1-git-send-email-bp@alien8.de Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--arch/x86/kernel/head_32.S4
-rw-r--r--arch/x86/kernel/head_64.S4
2 files changed, 4 insertions, 4 deletions
diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
index d031bad9e07e..02d257256200 100644
--- a/arch/x86/kernel/head_32.S
+++ b/arch/x86/kernel/head_32.S
@@ -547,7 +547,7 @@ ENTRY(early_idt_handler)
547 cld 547 cld
548 548
549 cmpl $2,(%esp) # X86_TRAP_NMI 549 cmpl $2,(%esp) # X86_TRAP_NMI
550 je is_nmi # Ignore NMI 550 je .Lis_nmi # Ignore NMI
551 551
552 cmpl $2,%ss:early_recursion_flag 552 cmpl $2,%ss:early_recursion_flag
553 je hlt_loop 553 je hlt_loop
@@ -600,7 +600,7 @@ ex_entry:
600 pop %ecx 600 pop %ecx
601 pop %eax 601 pop %eax
602 decl %ss:early_recursion_flag 602 decl %ss:early_recursion_flag
603is_nmi: 603.Lis_nmi:
604 addl $8,%esp /* drop vector number and error code */ 604 addl $8,%esp /* drop vector number and error code */
605 iret 605 iret
606ENDPROC(early_idt_handler) 606ENDPROC(early_idt_handler)
diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
index ae6588b301c2..43eafc8afb69 100644
--- a/arch/x86/kernel/head_64.S
+++ b/arch/x86/kernel/head_64.S
@@ -344,7 +344,7 @@ ENTRY(early_idt_handler)
344 cld 344 cld
345 345
346 cmpl $2,(%rsp) # X86_TRAP_NMI 346 cmpl $2,(%rsp) # X86_TRAP_NMI
347 je is_nmi # Ignore NMI 347 je .Lis_nmi # Ignore NMI
348 348
349 cmpl $2,early_recursion_flag(%rip) 349 cmpl $2,early_recursion_flag(%rip)
350 jz 1f 350 jz 1f
@@ -409,7 +409,7 @@ ENTRY(early_idt_handler)
409 popq %rcx 409 popq %rcx
410 popq %rax 410 popq %rax
411 decl early_recursion_flag(%rip) 411 decl early_recursion_flag(%rip)
412is_nmi: 412.Lis_nmi:
413 addq $16,%rsp # drop vector number and error code 413 addq $16,%rsp # drop vector number and error code
414 INTERRUPT_RETURN 414 INTERRUPT_RETURN
415ENDPROC(early_idt_handler) 415ENDPROC(early_idt_handler)