aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJiang Qiu <qiujiang@huawei.com>2016-04-28 05:32:01 -0400
committerLinus Walleij <linus.walleij@linaro.org>2016-04-29 05:22:53 -0400
commite81591815de05572ed28cbdca631d4d97f0bd059 (patch)
treeff66c93460d3c41bc56bedbb42d1086dcb5ec5d6
parenta8fa91a74fc385da5d52fd1008c8fd322154cad8 (diff)
gpio: dwapb: remove name from dwapb_port_property
This patch removed the name property from dwapb_port_property. The name property is redundant, since we can get this info from dwapb_gpio dev node. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Jiang Qiu <qiujiang@huawei.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r--drivers/gpio/gpio-dwapb.c24
-rw-r--r--drivers/mfd/intel_quark_i2c_gpio.c1
-rw-r--r--include/linux/platform_data/gpio-dwapb.h1
3 files changed, 11 insertions, 15 deletions
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 597de1ef497b..772d74383253 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -409,8 +409,8 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
409 err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout, 409 err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout,
410 NULL, false); 410 NULL, false);
411 if (err) { 411 if (err) {
412 dev_err(gpio->dev, "failed to init gpio chip for %s\n", 412 dev_err(gpio->dev, "failed to init gpio chip for port%d\n",
413 pp->name); 413 port->idx);
414 return err; 414 return err;
415 } 415 }
416 416
@@ -429,8 +429,8 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio,
429 429
430 err = gpiochip_add_data(&port->gc, port); 430 err = gpiochip_add_data(&port->gc, port);
431 if (err) 431 if (err)
432 dev_err(gpio->dev, "failed to register gpiochip for %s\n", 432 dev_err(gpio->dev, "failed to register gpiochip for port%d\n",
433 pp->name); 433 port->idx);
434 else 434 else
435 port->is_registered = true; 435 port->is_registered = true;
436 436
@@ -480,15 +480,16 @@ dwapb_gpio_get_pdata_of(struct device *dev)
480 480
481 if (of_property_read_u32(port_np, "reg", &pp->idx) || 481 if (of_property_read_u32(port_np, "reg", &pp->idx) ||
482 pp->idx >= DWAPB_MAX_PORTS) { 482 pp->idx >= DWAPB_MAX_PORTS) {
483 dev_err(dev, "missing/invalid port index for %s\n", 483 dev_err(dev,
484 port_np->full_name); 484 "missing/invalid port index for port%d\n", i);
485 return ERR_PTR(-EINVAL); 485 return ERR_PTR(-EINVAL);
486 } 486 }
487 487
488 if (of_property_read_u32(port_np, "snps,nr-gpios", 488 if (of_property_read_u32(port_np, "snps,nr-gpios",
489 &pp->ngpio)) { 489 &pp->ngpio)) {
490 dev_info(dev, "failed to get number of gpios for %s\n", 490 dev_info(dev,
491 port_np->full_name); 491 "failed to get number of gpios for port%d\n",
492 i);
492 pp->ngpio = 32; 493 pp->ngpio = 32;
493 } 494 }
494 495
@@ -499,15 +500,12 @@ dwapb_gpio_get_pdata_of(struct device *dev)
499 if (pp->idx == 0 && 500 if (pp->idx == 0 &&
500 of_property_read_bool(port_np, "interrupt-controller")) { 501 of_property_read_bool(port_np, "interrupt-controller")) {
501 pp->irq = irq_of_parse_and_map(port_np, 0); 502 pp->irq = irq_of_parse_and_map(port_np, 0);
502 if (!pp->irq) { 503 if (!pp->irq)
503 dev_warn(dev, "no irq for bank %s\n", 504 dev_warn(dev, "no irq for port%d\n", pp->idx);
504 port_np->full_name);
505 }
506 } 505 }
507 506
508 pp->irq_shared = false; 507 pp->irq_shared = false;
509 pp->gpio_base = -1; 508 pp->gpio_base = -1;
510 pp->name = port_np->full_name;
511 } 509 }
512 510
513 return pdata; 511 return pdata;
diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
index bdc5e27222c0..a4ef99b88924 100644
--- a/drivers/mfd/intel_quark_i2c_gpio.c
+++ b/drivers/mfd/intel_quark_i2c_gpio.c
@@ -220,7 +220,6 @@ static int intel_quark_gpio_setup(struct pci_dev *pdev, struct mfd_cell *cell)
220 220
221 /* Set the properties for portA */ 221 /* Set the properties for portA */
222 pdata->properties->node = NULL; 222 pdata->properties->node = NULL;
223 pdata->properties->name = "intel-quark-x1000-gpio-portA";
224 pdata->properties->idx = 0; 223 pdata->properties->idx = 0;
225 pdata->properties->ngpio = INTEL_QUARK_MFD_NGPIO; 224 pdata->properties->ngpio = INTEL_QUARK_MFD_NGPIO;
226 pdata->properties->gpio_base = INTEL_QUARK_MFD_GPIO_BASE; 225 pdata->properties->gpio_base = INTEL_QUARK_MFD_GPIO_BASE;
diff --git a/include/linux/platform_data/gpio-dwapb.h b/include/linux/platform_data/gpio-dwapb.h
index 28702c849af1..955b5790d24a 100644
--- a/include/linux/platform_data/gpio-dwapb.h
+++ b/include/linux/platform_data/gpio-dwapb.h
@@ -16,7 +16,6 @@
16 16
17struct dwapb_port_property { 17struct dwapb_port_property {
18 struct device_node *node; 18 struct device_node *node;
19 const char *name;
20 unsigned int idx; 19 unsigned int idx;
21 unsigned int ngpio; 20 unsigned int ngpio;
22 unsigned int gpio_base; 21 unsigned int gpio_base;