diff options
author | Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> | 2014-10-01 07:33:29 -0400 |
---|---|---|
committer | Brian Norris <computersforpeace@gmail.com> | 2014-10-07 02:40:07 -0400 |
commit | e7cd6824fd4105ff164aabc3767f195d1f6e4025 (patch) | |
tree | 72b88e36411fbf306f3e67cc9ad51d648228eec2 | |
parent | 32f1b7c8352fd33d41bcec3cfb054ccdcfd40a42 (diff) |
mtd: nand: Force omap_elm to be built as a module if omap2_nand is a module
This commit adds a hidden option to build the omap_elm as a module, if
omap2_nand is a module (and similarly in the built-in case).
This fixes the following build error when omap2_nand is chosen built-in,
and omap_elm is chosen as a module:
drivers/built-in.o: In function `omap_nand_probe':
drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config'
drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config'
drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config'
drivers/built-in.o: In function `omap_elm_correct_data':
drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page'
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
-rw-r--r-- | drivers/mtd/nand/Kconfig | 5 | ||||
-rw-r--r-- | drivers/mtd/nand/Makefile | 2 |
2 files changed, 5 insertions, 2 deletions
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index f1cf503517fd..1cb4b1ba59ec 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig | |||
@@ -96,7 +96,7 @@ config MTD_NAND_OMAP2 | |||
96 | 96 | ||
97 | config MTD_NAND_OMAP_BCH | 97 | config MTD_NAND_OMAP_BCH |
98 | depends on MTD_NAND_OMAP2 | 98 | depends on MTD_NAND_OMAP2 |
99 | tristate "Support hardware based BCH error correction" | 99 | bool "Support hardware based BCH error correction" |
100 | default n | 100 | default n |
101 | select BCH | 101 | select BCH |
102 | help | 102 | help |
@@ -106,6 +106,9 @@ config MTD_NAND_OMAP_BCH | |||
106 | legacy OMAP families like OMAP2xxx, OMAP3xxx do not have ELM engine | 106 | legacy OMAP families like OMAP2xxx, OMAP3xxx do not have ELM engine |
107 | so they should not enable this config symbol. | 107 | so they should not enable this config symbol. |
108 | 108 | ||
109 | config MTD_NAND_OMAP_BCH_BUILD | ||
110 | def_tristate MTD_NAND_OMAP2 && MTD_NAND_OMAP_BCH | ||
111 | |||
109 | config MTD_NAND_IDS | 112 | config MTD_NAND_IDS |
110 | tristate | 113 | tristate |
111 | 114 | ||
diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index b3237b742eb5..9c847e469ca7 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile | |||
@@ -27,7 +27,7 @@ obj-$(CONFIG_MTD_NAND_NDFC) += ndfc.o | |||
27 | obj-$(CONFIG_MTD_NAND_ATMEL) += atmel_nand.o | 27 | obj-$(CONFIG_MTD_NAND_ATMEL) += atmel_nand.o |
28 | obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o | 28 | obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o |
29 | obj-$(CONFIG_MTD_NAND_OMAP2) += omap2.o | 29 | obj-$(CONFIG_MTD_NAND_OMAP2) += omap2.o |
30 | obj-$(CONFIG_MTD_NAND_OMAP_BCH) += omap_elm.o | 30 | obj-$(CONFIG_MTD_NAND_OMAP_BCH_BUILD) += omap_elm.o |
31 | obj-$(CONFIG_MTD_NAND_CM_X270) += cmx270_nand.o | 31 | obj-$(CONFIG_MTD_NAND_CM_X270) += cmx270_nand.o |
32 | obj-$(CONFIG_MTD_NAND_PXA3xx) += pxa3xx_nand.o | 32 | obj-$(CONFIG_MTD_NAND_PXA3xx) += pxa3xx_nand.o |
33 | obj-$(CONFIG_MTD_NAND_TMIO) += tmio_nand.o | 33 | obj-$(CONFIG_MTD_NAND_TMIO) += tmio_nand.o |