diff options
author | Russell King <rmk+kernel@arm.linux.org.uk> | 2015-06-06 16:41:10 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2015-09-15 11:19:48 -0400 |
commit | e66e03abf80f701da60ae085cbb913e67ce6741d (patch) | |
tree | 322f65cb42d38fef556b5d08d04d998179b639d6 | |
parent | 0fc6f44d9683c61678da4b0eebc89e8fa624de39 (diff) |
drm/i2c: tda998x: convert to u8/u16/u32 types
C99 types are against the style of the Linux kernel. Convert to using
Linus-friendly types. See https://lwn.net/Articles/113367/ for more
information.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
-rw-r--r-- | drivers/gpu/drm/i2c/tda998x_drv.c | 74 |
1 files changed, 37 insertions, 37 deletions
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index a53696fd8938..6d6aaadc0d2f 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c | |||
@@ -34,8 +34,8 @@ struct tda998x_priv { | |||
34 | struct i2c_client *cec; | 34 | struct i2c_client *cec; |
35 | struct i2c_client *hdmi; | 35 | struct i2c_client *hdmi; |
36 | struct mutex mutex; | 36 | struct mutex mutex; |
37 | uint16_t rev; | 37 | u16 rev; |
38 | uint8_t current_page; | 38 | u8 current_page; |
39 | int dpms; | 39 | int dpms; |
40 | bool is_hdmi_sink; | 40 | bool is_hdmi_sink; |
41 | u8 vip_cntrl_0; | 41 | u8 vip_cntrl_0; |
@@ -349,10 +349,10 @@ struct tda998x_priv { | |||
349 | #define TDA19988 0x0301 | 349 | #define TDA19988 0x0301 |
350 | 350 | ||
351 | static void | 351 | static void |
352 | cec_write(struct tda998x_priv *priv, uint16_t addr, uint8_t val) | 352 | cec_write(struct tda998x_priv *priv, u16 addr, u8 val) |
353 | { | 353 | { |
354 | struct i2c_client *client = priv->cec; | 354 | struct i2c_client *client = priv->cec; |
355 | uint8_t buf[] = {addr, val}; | 355 | u8 buf[] = {addr, val}; |
356 | int ret; | 356 | int ret; |
357 | 357 | ||
358 | ret = i2c_master_send(client, buf, sizeof(buf)); | 358 | ret = i2c_master_send(client, buf, sizeof(buf)); |
@@ -360,11 +360,11 @@ cec_write(struct tda998x_priv *priv, uint16_t addr, uint8_t val) | |||
360 | dev_err(&client->dev, "Error %d writing to cec:0x%x\n", ret, addr); | 360 | dev_err(&client->dev, "Error %d writing to cec:0x%x\n", ret, addr); |
361 | } | 361 | } |
362 | 362 | ||
363 | static uint8_t | 363 | static u8 |
364 | cec_read(struct tda998x_priv *priv, uint8_t addr) | 364 | cec_read(struct tda998x_priv *priv, u8 addr) |
365 | { | 365 | { |
366 | struct i2c_client *client = priv->cec; | 366 | struct i2c_client *client = priv->cec; |
367 | uint8_t val; | 367 | u8 val; |
368 | int ret; | 368 | int ret; |
369 | 369 | ||
370 | ret = i2c_master_send(client, &addr, sizeof(addr)); | 370 | ret = i2c_master_send(client, &addr, sizeof(addr)); |
@@ -383,11 +383,11 @@ fail: | |||
383 | } | 383 | } |
384 | 384 | ||
385 | static int | 385 | static int |
386 | set_page(struct tda998x_priv *priv, uint16_t reg) | 386 | set_page(struct tda998x_priv *priv, u16 reg) |
387 | { | 387 | { |
388 | if (REG2PAGE(reg) != priv->current_page) { | 388 | if (REG2PAGE(reg) != priv->current_page) { |
389 | struct i2c_client *client = priv->hdmi; | 389 | struct i2c_client *client = priv->hdmi; |
390 | uint8_t buf[] = { | 390 | u8 buf[] = { |
391 | REG_CURPAGE, REG2PAGE(reg) | 391 | REG_CURPAGE, REG2PAGE(reg) |
392 | }; | 392 | }; |
393 | int ret = i2c_master_send(client, buf, sizeof(buf)); | 393 | int ret = i2c_master_send(client, buf, sizeof(buf)); |
@@ -403,10 +403,10 @@ set_page(struct tda998x_priv *priv, uint16_t reg) | |||
403 | } | 403 | } |
404 | 404 | ||
405 | static int | 405 | static int |
406 | reg_read_range(struct tda998x_priv *priv, uint16_t reg, char *buf, int cnt) | 406 | reg_read_range(struct tda998x_priv *priv, u16 reg, char *buf, int cnt) |
407 | { | 407 | { |
408 | struct i2c_client *client = priv->hdmi; | 408 | struct i2c_client *client = priv->hdmi; |
409 | uint8_t addr = REG2ADDR(reg); | 409 | u8 addr = REG2ADDR(reg); |
410 | int ret; | 410 | int ret; |
411 | 411 | ||
412 | mutex_lock(&priv->mutex); | 412 | mutex_lock(&priv->mutex); |
@@ -432,10 +432,10 @@ out: | |||
432 | } | 432 | } |
433 | 433 | ||
434 | static void | 434 | static void |
435 | reg_write_range(struct tda998x_priv *priv, uint16_t reg, uint8_t *p, int cnt) | 435 | reg_write_range(struct tda998x_priv *priv, u16 reg, u8 *p, int cnt) |
436 | { | 436 | { |
437 | struct i2c_client *client = priv->hdmi; | 437 | struct i2c_client *client = priv->hdmi; |
438 | uint8_t buf[cnt+1]; | 438 | u8 buf[cnt+1]; |
439 | int ret; | 439 | int ret; |
440 | 440 | ||
441 | buf[0] = REG2ADDR(reg); | 441 | buf[0] = REG2ADDR(reg); |
@@ -454,9 +454,9 @@ out: | |||
454 | } | 454 | } |
455 | 455 | ||
456 | static int | 456 | static int |
457 | reg_read(struct tda998x_priv *priv, uint16_t reg) | 457 | reg_read(struct tda998x_priv *priv, u16 reg) |
458 | { | 458 | { |
459 | uint8_t val = 0; | 459 | u8 val = 0; |
460 | int ret; | 460 | int ret; |
461 | 461 | ||
462 | ret = reg_read_range(priv, reg, &val, sizeof(val)); | 462 | ret = reg_read_range(priv, reg, &val, sizeof(val)); |
@@ -466,10 +466,10 @@ reg_read(struct tda998x_priv *priv, uint16_t reg) | |||
466 | } | 466 | } |
467 | 467 | ||
468 | static void | 468 | static void |
469 | reg_write(struct tda998x_priv *priv, uint16_t reg, uint8_t val) | 469 | reg_write(struct tda998x_priv *priv, u16 reg, u8 val) |
470 | { | 470 | { |
471 | struct i2c_client *client = priv->hdmi; | 471 | struct i2c_client *client = priv->hdmi; |
472 | uint8_t buf[] = {REG2ADDR(reg), val}; | 472 | u8 buf[] = {REG2ADDR(reg), val}; |
473 | int ret; | 473 | int ret; |
474 | 474 | ||
475 | mutex_lock(&priv->mutex); | 475 | mutex_lock(&priv->mutex); |
@@ -485,10 +485,10 @@ out: | |||
485 | } | 485 | } |
486 | 486 | ||
487 | static void | 487 | static void |
488 | reg_write16(struct tda998x_priv *priv, uint16_t reg, uint16_t val) | 488 | reg_write16(struct tda998x_priv *priv, u16 reg, u16 val) |
489 | { | 489 | { |
490 | struct i2c_client *client = priv->hdmi; | 490 | struct i2c_client *client = priv->hdmi; |
491 | uint8_t buf[] = {REG2ADDR(reg), val >> 8, val}; | 491 | u8 buf[] = {REG2ADDR(reg), val >> 8, val}; |
492 | int ret; | 492 | int ret; |
493 | 493 | ||
494 | mutex_lock(&priv->mutex); | 494 | mutex_lock(&priv->mutex); |
@@ -504,7 +504,7 @@ out: | |||
504 | } | 504 | } |
505 | 505 | ||
506 | static void | 506 | static void |
507 | reg_set(struct tda998x_priv *priv, uint16_t reg, uint8_t val) | 507 | reg_set(struct tda998x_priv *priv, u16 reg, u8 val) |
508 | { | 508 | { |
509 | int old_val; | 509 | int old_val; |
510 | 510 | ||
@@ -514,7 +514,7 @@ reg_set(struct tda998x_priv *priv, uint16_t reg, uint8_t val) | |||
514 | } | 514 | } |
515 | 515 | ||
516 | static void | 516 | static void |
517 | reg_clear(struct tda998x_priv *priv, uint16_t reg, uint8_t val) | 517 | reg_clear(struct tda998x_priv *priv, u16 reg, u8 val) |
518 | { | 518 | { |
519 | int old_val; | 519 | int old_val; |
520 | 520 | ||
@@ -634,7 +634,7 @@ static irqreturn_t tda998x_irq_thread(int irq, void *data) | |||
634 | return IRQ_RETVAL(handled); | 634 | return IRQ_RETVAL(handled); |
635 | } | 635 | } |
636 | 636 | ||
637 | static uint8_t tda998x_cksum(uint8_t *buf, size_t bytes) | 637 | static u8 tda998x_cksum(u8 *buf, size_t bytes) |
638 | { | 638 | { |
639 | int sum = 0; | 639 | int sum = 0; |
640 | 640 | ||
@@ -647,8 +647,8 @@ static uint8_t tda998x_cksum(uint8_t *buf, size_t bytes) | |||
647 | #define PB(x) (HB(2) + 1 + (x)) | 647 | #define PB(x) (HB(2) + 1 + (x)) |
648 | 648 | ||
649 | static void | 649 | static void |
650 | tda998x_write_if(struct tda998x_priv *priv, uint8_t bit, uint16_t addr, | 650 | tda998x_write_if(struct tda998x_priv *priv, u8 bit, u16 addr, |
651 | uint8_t *buf, size_t size) | 651 | u8 *buf, size_t size) |
652 | { | 652 | { |
653 | reg_clear(priv, REG_DIP_IF_FLAGS, bit); | 653 | reg_clear(priv, REG_DIP_IF_FLAGS, bit); |
654 | reg_write_range(priv, addr, buf, size); | 654 | reg_write_range(priv, addr, buf, size); |
@@ -711,8 +711,8 @@ static void | |||
711 | tda998x_configure_audio(struct tda998x_priv *priv, | 711 | tda998x_configure_audio(struct tda998x_priv *priv, |
712 | struct drm_display_mode *mode, struct tda998x_encoder_params *p) | 712 | struct drm_display_mode *mode, struct tda998x_encoder_params *p) |
713 | { | 713 | { |
714 | uint8_t buf[6], clksel_aip, clksel_fs, cts_n, adiv; | 714 | u8 buf[6], clksel_aip, clksel_fs, cts_n, adiv; |
715 | uint32_t n; | 715 | u32 n; |
716 | 716 | ||
717 | /* Enable audio ports */ | 717 | /* Enable audio ports */ |
718 | reg_write(priv, REG_ENA_AP, p->audio_cfg); | 718 | reg_write(priv, REG_ENA_AP, p->audio_cfg); |
@@ -888,14 +888,14 @@ tda998x_encoder_mode_set(struct tda998x_priv *priv, | |||
888 | struct drm_display_mode *mode, | 888 | struct drm_display_mode *mode, |
889 | struct drm_display_mode *adjusted_mode) | 889 | struct drm_display_mode *adjusted_mode) |
890 | { | 890 | { |
891 | uint16_t ref_pix, ref_line, n_pix, n_line; | 891 | u16 ref_pix, ref_line, n_pix, n_line; |
892 | uint16_t hs_pix_s, hs_pix_e; | 892 | u16 hs_pix_s, hs_pix_e; |
893 | uint16_t vs1_pix_s, vs1_pix_e, vs1_line_s, vs1_line_e; | 893 | u16 vs1_pix_s, vs1_pix_e, vs1_line_s, vs1_line_e; |
894 | uint16_t vs2_pix_s, vs2_pix_e, vs2_line_s, vs2_line_e; | 894 | u16 vs2_pix_s, vs2_pix_e, vs2_line_s, vs2_line_e; |
895 | uint16_t vwin1_line_s, vwin1_line_e; | 895 | u16 vwin1_line_s, vwin1_line_e; |
896 | uint16_t vwin2_line_s, vwin2_line_e; | 896 | u16 vwin2_line_s, vwin2_line_e; |
897 | uint16_t de_pix_s, de_pix_e; | 897 | u16 de_pix_s, de_pix_e; |
898 | uint8_t reg, div, rep; | 898 | u8 reg, div, rep; |
899 | 899 | ||
900 | /* | 900 | /* |
901 | * Internally TDA998x is using ITU-R BT.656 style sync but | 901 | * Internally TDA998x is using ITU-R BT.656 style sync but |
@@ -1077,7 +1077,7 @@ tda998x_encoder_mode_set(struct tda998x_priv *priv, | |||
1077 | static enum drm_connector_status | 1077 | static enum drm_connector_status |
1078 | tda998x_encoder_detect(struct tda998x_priv *priv) | 1078 | tda998x_encoder_detect(struct tda998x_priv *priv) |
1079 | { | 1079 | { |
1080 | uint8_t val = cec_read(priv, REG_CEC_RXSHPDLEV); | 1080 | u8 val = cec_read(priv, REG_CEC_RXSHPDLEV); |
1081 | 1081 | ||
1082 | return (val & CEC_RXSHPDLEV_HPD) ? connector_status_connected : | 1082 | return (val & CEC_RXSHPDLEV_HPD) ? connector_status_connected : |
1083 | connector_status_disconnected; | 1083 | connector_status_disconnected; |
@@ -1086,7 +1086,7 @@ tda998x_encoder_detect(struct tda998x_priv *priv) | |||
1086 | static int read_edid_block(void *data, u8 *buf, unsigned int blk, size_t length) | 1086 | static int read_edid_block(void *data, u8 *buf, unsigned int blk, size_t length) |
1087 | { | 1087 | { |
1088 | struct tda998x_priv *priv = data; | 1088 | struct tda998x_priv *priv = data; |
1089 | uint8_t offset, segptr; | 1089 | u8 offset, segptr; |
1090 | int ret, i; | 1090 | int ret, i; |
1091 | 1091 | ||
1092 | offset = (blk & 1) ? 128 : 0; | 1092 | offset = (blk & 1) ? 128 : 0; |
@@ -1558,7 +1558,7 @@ static int tda998x_bind(struct device *dev, struct device *master, void *data) | |||
1558 | struct i2c_client *client = to_i2c_client(dev); | 1558 | struct i2c_client *client = to_i2c_client(dev); |
1559 | struct drm_device *drm = data; | 1559 | struct drm_device *drm = data; |
1560 | struct tda998x_priv2 *priv; | 1560 | struct tda998x_priv2 *priv; |
1561 | uint32_t crtcs = 0; | 1561 | u32 crtcs = 0; |
1562 | int ret; | 1562 | int ret; |
1563 | 1563 | ||
1564 | priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); | 1564 | priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); |