aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>2019-04-12 06:59:36 -0400
committerJames Morris <jamorris@linux.microsoft.com>2019-05-10 17:58:25 -0400
commite6193f78bb689f3f424559bb45f4a091c8b314df (patch)
tree8c51acf92c910b500cd4622df6e11b949de7118b
parente80b18599a39a625bc8b2e39ba3004a62f78805a (diff)
tomoyo: Check address length before reading address family
KMSAN will complain if valid address length passed to bind()/connect()/ sendmsg() is shorter than sizeof("struct sockaddr"->sa_family) bytes. Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: James Morris <jamorris@linux.microsoft.com>
-rw-r--r--security/tomoyo/network.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/security/tomoyo/network.c b/security/tomoyo/network.c
index 9094f4b3b367..f9ff121d7e1e 100644
--- a/security/tomoyo/network.c
+++ b/security/tomoyo/network.c
@@ -505,6 +505,8 @@ static int tomoyo_check_inet_address(const struct sockaddr *addr,
505{ 505{
506 struct tomoyo_inet_addr_info *i = &address->inet; 506 struct tomoyo_inet_addr_info *i = &address->inet;
507 507
508 if (addr_len < offsetofend(struct sockaddr, sa_family))
509 return 0;
508 switch (addr->sa_family) { 510 switch (addr->sa_family) {
509 case AF_INET6: 511 case AF_INET6:
510 if (addr_len < SIN6_LEN_RFC2133) 512 if (addr_len < SIN6_LEN_RFC2133)
@@ -594,6 +596,8 @@ static int tomoyo_check_unix_address(struct sockaddr *addr,
594{ 596{
595 struct tomoyo_unix_addr_info *u = &address->unix0; 597 struct tomoyo_unix_addr_info *u = &address->unix0;
596 598
599 if (addr_len < offsetofend(struct sockaddr, sa_family))
600 return 0;
597 if (addr->sa_family != AF_UNIX) 601 if (addr->sa_family != AF_UNIX)
598 return 0; 602 return 0;
599 u->addr = ((struct sockaddr_un *) addr)->sun_path; 603 u->addr = ((struct sockaddr_un *) addr)->sun_path;