diff options
author | Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> | 2017-03-08 20:18:09 -0500 |
---|---|---|
committer | Borislav Petkov <bp@suse.de> | 2017-03-09 03:25:29 -0500 |
commit | e61555c29c28a4a3b6ba6207f4a0883ee236004d (patch) | |
tree | e0b294ea0f682cf3ca0a68f3c16e353d04f02466 | |
parent | 4bd035eae255a4f1464dca063885fa415e58c12e (diff) |
EDAC, i5000, i5400: Fix use of MTR_DRAM_WIDTH macro
The MTR_DRAM_WIDTH macro returns the data width. It is sometimes used
as if it returned a boolean true if the width if 8. Fix the tests where
MTR_DRAM_WIDTH is misused.
Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20170309011809.8340-1-jeremy.lefaure@lse.epita.fr
Signed-off-by: Borislav Petkov <bp@suse.de>
-rw-r--r-- | drivers/edac/i5000_edac.c | 2 | ||||
-rw-r--r-- | drivers/edac/i5400_edac.c | 5 |
2 files changed, 4 insertions, 3 deletions
diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c index 1670d27bcac8..f683919981b0 100644 --- a/drivers/edac/i5000_edac.c +++ b/drivers/edac/i5000_edac.c | |||
@@ -1293,7 +1293,7 @@ static int i5000_init_csrows(struct mem_ctl_info *mci) | |||
1293 | dimm->mtype = MEM_FB_DDR2; | 1293 | dimm->mtype = MEM_FB_DDR2; |
1294 | 1294 | ||
1295 | /* ask what device type on this row */ | 1295 | /* ask what device type on this row */ |
1296 | if (MTR_DRAM_WIDTH(mtr)) | 1296 | if (MTR_DRAM_WIDTH(mtr) == 8) |
1297 | dimm->dtype = DEV_X8; | 1297 | dimm->dtype = DEV_X8; |
1298 | else | 1298 | else |
1299 | dimm->dtype = DEV_X4; | 1299 | dimm->dtype = DEV_X4; |
diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c index abf6ef22e220..37a9ba71da44 100644 --- a/drivers/edac/i5400_edac.c +++ b/drivers/edac/i5400_edac.c | |||
@@ -1207,13 +1207,14 @@ static int i5400_init_dimms(struct mem_ctl_info *mci) | |||
1207 | 1207 | ||
1208 | dimm->nr_pages = size_mb << 8; | 1208 | dimm->nr_pages = size_mb << 8; |
1209 | dimm->grain = 8; | 1209 | dimm->grain = 8; |
1210 | dimm->dtype = MTR_DRAM_WIDTH(mtr) ? DEV_X8 : DEV_X4; | 1210 | dimm->dtype = MTR_DRAM_WIDTH(mtr) == 8 ? |
1211 | DEV_X8 : DEV_X4; | ||
1211 | dimm->mtype = MEM_FB_DDR2; | 1212 | dimm->mtype = MEM_FB_DDR2; |
1212 | /* | 1213 | /* |
1213 | * The eccc mechanism is SDDC (aka SECC), with | 1214 | * The eccc mechanism is SDDC (aka SECC), with |
1214 | * is similar to Chipkill. | 1215 | * is similar to Chipkill. |
1215 | */ | 1216 | */ |
1216 | dimm->edac_mode = MTR_DRAM_WIDTH(mtr) ? | 1217 | dimm->edac_mode = MTR_DRAM_WIDTH(mtr) == 8 ? |
1217 | EDAC_S8ECD8ED : EDAC_S4ECD4ED; | 1218 | EDAC_S8ECD8ED : EDAC_S4ECD4ED; |
1218 | ndimms++; | 1219 | ndimms++; |
1219 | } | 1220 | } |