diff options
author | Ingo Molnar <mingo@kernel.org> | 2014-01-15 01:39:30 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-01-15 01:39:30 -0500 |
commit | e59da0aedb573a347fa501fa63d3ff5055aa1bc7 (patch) | |
tree | e112b0803a87915b648588765716bdbcc34d5b67 | |
parent | a6da83f98267bc8ee4e34aa899169991eb0ceb93 (diff) | |
parent | c1dcc927dae01dfd4904ee82ce2c00b50eab6dc3 (diff) |
Merge branch 'clockevents/3.13-fixes' of git://git.linaro.org/people/daniel.lezcano/linux into timers/urgent
Pull clock driver fix from Daniel Lezcano:
" * Soren Brinkmann fixed the cadence_ttc driver where a call to
clk_get_rate happens in an interrupt context. More precisely in an IPI
when the broadcast timer is initialized for each cpu in the cpuidle
driver. "
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | drivers/clocksource/cadence_ttc_timer.c | 21 |
1 files changed, 13 insertions, 8 deletions
diff --git a/drivers/clocksource/cadence_ttc_timer.c b/drivers/clocksource/cadence_ttc_timer.c index b2bb3a4bc205..a92350b55d32 100644 --- a/drivers/clocksource/cadence_ttc_timer.c +++ b/drivers/clocksource/cadence_ttc_timer.c | |||
@@ -67,11 +67,13 @@ | |||
67 | * struct ttc_timer - This definition defines local timer structure | 67 | * struct ttc_timer - This definition defines local timer structure |
68 | * | 68 | * |
69 | * @base_addr: Base address of timer | 69 | * @base_addr: Base address of timer |
70 | * @freq: Timer input clock frequency | ||
70 | * @clk: Associated clock source | 71 | * @clk: Associated clock source |
71 | * @clk_rate_change_nb Notifier block for clock rate changes | 72 | * @clk_rate_change_nb Notifier block for clock rate changes |
72 | */ | 73 | */ |
73 | struct ttc_timer { | 74 | struct ttc_timer { |
74 | void __iomem *base_addr; | 75 | void __iomem *base_addr; |
76 | unsigned long freq; | ||
75 | struct clk *clk; | 77 | struct clk *clk; |
76 | struct notifier_block clk_rate_change_nb; | 78 | struct notifier_block clk_rate_change_nb; |
77 | }; | 79 | }; |
@@ -196,9 +198,8 @@ static void ttc_set_mode(enum clock_event_mode mode, | |||
196 | 198 | ||
197 | switch (mode) { | 199 | switch (mode) { |
198 | case CLOCK_EVT_MODE_PERIODIC: | 200 | case CLOCK_EVT_MODE_PERIODIC: |
199 | ttc_set_interval(timer, | 201 | ttc_set_interval(timer, DIV_ROUND_CLOSEST(ttce->ttc.freq, |
200 | DIV_ROUND_CLOSEST(clk_get_rate(ttce->ttc.clk), | 202 | PRESCALE * HZ)); |
201 | PRESCALE * HZ)); | ||
202 | break; | 203 | break; |
203 | case CLOCK_EVT_MODE_ONESHOT: | 204 | case CLOCK_EVT_MODE_ONESHOT: |
204 | case CLOCK_EVT_MODE_UNUSED: | 205 | case CLOCK_EVT_MODE_UNUSED: |
@@ -273,6 +274,8 @@ static void __init ttc_setup_clocksource(struct clk *clk, void __iomem *base) | |||
273 | return; | 274 | return; |
274 | } | 275 | } |
275 | 276 | ||
277 | ttccs->ttc.freq = clk_get_rate(ttccs->ttc.clk); | ||
278 | |||
276 | ttccs->ttc.clk_rate_change_nb.notifier_call = | 279 | ttccs->ttc.clk_rate_change_nb.notifier_call = |
277 | ttc_rate_change_clocksource_cb; | 280 | ttc_rate_change_clocksource_cb; |
278 | ttccs->ttc.clk_rate_change_nb.next = NULL; | 281 | ttccs->ttc.clk_rate_change_nb.next = NULL; |
@@ -298,16 +301,14 @@ static void __init ttc_setup_clocksource(struct clk *clk, void __iomem *base) | |||
298 | __raw_writel(CNT_CNTRL_RESET, | 301 | __raw_writel(CNT_CNTRL_RESET, |
299 | ttccs->ttc.base_addr + TTC_CNT_CNTRL_OFFSET); | 302 | ttccs->ttc.base_addr + TTC_CNT_CNTRL_OFFSET); |
300 | 303 | ||
301 | err = clocksource_register_hz(&ttccs->cs, | 304 | err = clocksource_register_hz(&ttccs->cs, ttccs->ttc.freq / PRESCALE); |
302 | clk_get_rate(ttccs->ttc.clk) / PRESCALE); | ||
303 | if (WARN_ON(err)) { | 305 | if (WARN_ON(err)) { |
304 | kfree(ttccs); | 306 | kfree(ttccs); |
305 | return; | 307 | return; |
306 | } | 308 | } |
307 | 309 | ||
308 | ttc_sched_clock_val_reg = base + TTC_COUNT_VAL_OFFSET; | 310 | ttc_sched_clock_val_reg = base + TTC_COUNT_VAL_OFFSET; |
309 | setup_sched_clock(ttc_sched_clock_read, 16, | 311 | setup_sched_clock(ttc_sched_clock_read, 16, ttccs->ttc.freq / PRESCALE); |
310 | clk_get_rate(ttccs->ttc.clk) / PRESCALE); | ||
311 | } | 312 | } |
312 | 313 | ||
313 | static int ttc_rate_change_clockevent_cb(struct notifier_block *nb, | 314 | static int ttc_rate_change_clockevent_cb(struct notifier_block *nb, |
@@ -334,6 +335,9 @@ static int ttc_rate_change_clockevent_cb(struct notifier_block *nb, | |||
334 | ndata->new_rate / PRESCALE); | 335 | ndata->new_rate / PRESCALE); |
335 | local_irq_restore(flags); | 336 | local_irq_restore(flags); |
336 | 337 | ||
338 | /* update cached frequency */ | ||
339 | ttc->freq = ndata->new_rate; | ||
340 | |||
337 | /* fall through */ | 341 | /* fall through */ |
338 | } | 342 | } |
339 | case PRE_RATE_CHANGE: | 343 | case PRE_RATE_CHANGE: |
@@ -367,6 +371,7 @@ static void __init ttc_setup_clockevent(struct clk *clk, | |||
367 | if (clk_notifier_register(ttcce->ttc.clk, | 371 | if (clk_notifier_register(ttcce->ttc.clk, |
368 | &ttcce->ttc.clk_rate_change_nb)) | 372 | &ttcce->ttc.clk_rate_change_nb)) |
369 | pr_warn("Unable to register clock notifier.\n"); | 373 | pr_warn("Unable to register clock notifier.\n"); |
374 | ttcce->ttc.freq = clk_get_rate(ttcce->ttc.clk); | ||
370 | 375 | ||
371 | ttcce->ttc.base_addr = base; | 376 | ttcce->ttc.base_addr = base; |
372 | ttcce->ce.name = "ttc_clockevent"; | 377 | ttcce->ce.name = "ttc_clockevent"; |
@@ -396,7 +401,7 @@ static void __init ttc_setup_clockevent(struct clk *clk, | |||
396 | } | 401 | } |
397 | 402 | ||
398 | clockevents_config_and_register(&ttcce->ce, | 403 | clockevents_config_and_register(&ttcce->ce, |
399 | clk_get_rate(ttcce->ttc.clk) / PRESCALE, 1, 0xfffe); | 404 | ttcce->ttc.freq / PRESCALE, 1, 0xfffe); |
400 | } | 405 | } |
401 | 406 | ||
402 | /** | 407 | /** |