Input: synaptics - fix handling of disabling gesture mode

Bit 2 of the mode byte has dual meaning: it can disable reporting of
gestures when touchpad works in Relative mode or normal Absolute mode,
or it can enable so called Extended W-Mode when touchpad uses enhanced
Absolute mode (W-mode). The extended W-Mode confuses our driver and
causes missing button presses on some Thinkpads (x250, T450s), so let's
make sure we do not enable it.

Also, according to the spec W mode "... bit is defined only in Absolute
mode on pads whose capExtended capability bit is set. In Relative mode and
in TouchPads without this capability, the bit is reserved and should be
left at 0.", so let's make sure we respect this requirement as well.

Reported-by: Nick Bowler <nbowler@draconx.ca>
Suggested-by: Gabor Balla <gaborwho@gmail.com>
Tested-by: Gabor Balla <gaborwho@gmail.com>
Tested-by: Nick Bowler <nbowler@draconx.ca>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

1 files changed, 8 insertions, 4 deletions

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 6025eb430c0a..994ae7886156 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -519,14 +519,18 @@ static int synaptics_set_mode(struct psmouse *psmouse)
         struct synaptics_data *priv = psmouse->private;
 
         priv->mode = 0;
-        if (priv->absolute_mode)
+
+        if (priv->absolute_mode) {
                 priv->mode |= SYN_BIT_ABSOLUTE_MODE;
-        if (priv->disable_gesture)
+                if (SYN_CAP_EXTENDED(priv->capabilities))
+                        priv->mode |= SYN_BIT_W_MODE;
+        }
+
+        if (!SYN_MODE_WMODE(priv->mode) && priv->disable_gesture)
                 priv->mode |= SYN_BIT_DISABLE_GESTURE;
+
         if (psmouse->rate >= 80)
                 priv->mode |= SYN_BIT_HIGH_RATE;
-        if (SYN_CAP_EXTENDED(priv->capabilities))
-                priv->mode |= SYN_BIT_W_MODE;
 
         if (synaptics_mode_cmd(psmouse, priv->mode))
                 return -1;