diff options
author | Richard Weinberger <richard@nod.at> | 2016-02-21 04:53:03 -0500 |
---|---|---|
committer | Richard Weinberger <richard@nod.at> | 2016-03-05 15:56:23 -0500 |
commit | e4f6daac20332448529b11f09388f1d55ef2084c (patch) | |
tree | 176dde53412c2d03a732188850394580159dade8 | |
parent | fc77dbd34c5c99bce46d40a2491937c3bcbd10af (diff) |
ubi: Fix out of bounds write in volume update code
ubi_start_leb_change() allocates too few bytes.
ubi_more_leb_change_data() will write up to req->upd_bytes +
ubi->min_io_size bytes.
Cc: stable@vger.kernel.org
Signed-off-by: Richard Weinberger <richard@nod.at>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
-rw-r--r-- | drivers/mtd/ubi/upd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/upd.c b/drivers/mtd/ubi/upd.c index 2a1b6e037e1a..0134ba32a057 100644 --- a/drivers/mtd/ubi/upd.c +++ b/drivers/mtd/ubi/upd.c | |||
@@ -193,7 +193,7 @@ int ubi_start_leb_change(struct ubi_device *ubi, struct ubi_volume *vol, | |||
193 | vol->changing_leb = 1; | 193 | vol->changing_leb = 1; |
194 | vol->ch_lnum = req->lnum; | 194 | vol->ch_lnum = req->lnum; |
195 | 195 | ||
196 | vol->upd_buf = vmalloc(req->bytes); | 196 | vol->upd_buf = vmalloc(ALIGN((int)req->bytes, ubi->min_io_size)); |
197 | if (!vol->upd_buf) | 197 | if (!vol->upd_buf) |
198 | return -ENOMEM; | 198 | return -ENOMEM; |
199 | 199 | ||