diff options
author | Axel Lin <axel.lin@ingics.com> | 2015-05-21 10:57:34 -0400 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2015-05-22 05:06:47 -0400 |
commit | e1a96fb861b0781c8ef66a76d0fc6fb6f628f84c (patch) | |
tree | ae82549fb97cae1a908d3993432ecedf2602283f | |
parent | a6c761e44cfdeffc31785c698aa04d310e7cd686 (diff) |
irqchip: mtk-sysirq: Make mtk_sysirq_of_init return error if ioremap fails
PTR_ERR(NULL) returns 0 so current code returns 0 if ioremap fails, fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: linux-mediatek@lists.infradead.org <linux-mediatek@lists.infradead.org>
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/1432220254.29544.1.camel@ingics.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r-- | drivers/irqchip/irq-mtk-sysirq.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c index 04de2d4ca70f..15c13039bba2 100644 --- a/drivers/irqchip/irq-mtk-sysirq.c +++ b/drivers/irqchip/irq-mtk-sysirq.c | |||
@@ -144,7 +144,7 @@ static int __init mtk_sysirq_of_init(struct device_node *node, | |||
144 | chip_data->intpol_base = ioremap(res.start, size); | 144 | chip_data->intpol_base = ioremap(res.start, size); |
145 | if (!chip_data->intpol_base) { | 145 | if (!chip_data->intpol_base) { |
146 | pr_err("mtk_sysirq: unable to map sysirq register\n"); | 146 | pr_err("mtk_sysirq: unable to map sysirq register\n"); |
147 | ret = PTR_ERR(chip_data->intpol_base); | 147 | ret = -ENXIO; |
148 | goto out_free; | 148 | goto out_free; |
149 | } | 149 | } |
150 | 150 | ||