diff options
author | Randy Dunlap <rdunlap@infradead.org> | 2018-01-31 19:21:19 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-01-31 20:18:40 -0500 |
commit | e02a9f048ef79a411904bef075fd3ce4204052a9 (patch) | |
tree | 442108a49402a43a88c814f5f5cf75722017c206 | |
parent | 9bb5a391f9a5707e04763cf14298fc4cc29bfecd (diff) |
mm/swap.c: make functions and their kernel-doc agree
Fix some basic kernel-doc notation in mm/swap.c:
- for function lru_cache_add_anon(), make its kernel-doc function name
match its function name and change colon to hyphen following the
function name
- for function pagevec_lookup_entries(), change the function parameter
name from nr_pages to nr_entries since that is more descriptive of
what the parameter actually is and then it matches the kernel-doc
comments also
Fix function kernel-doc to match the change in commit 67fd707f4681:
- drop the kernel-doc notation for @nr_pages from
pagevec_lookup_range() and correct the function description for that
change
Link: http://lkml.kernel.org/r/3b42ee3e-04a9-a6ca-6be4-f00752a114fe@infradead.org
Fixes: 67fd707f4681 ("mm: remove nr_pages argument from pagevec_lookup_{,range}_tag()")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Hugh Dickins <hughd@google.com>
Cc: Michal Hocko <mhocko@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | mm/swap.c | 11 |
1 files changed, 5 insertions, 6 deletions
@@ -411,7 +411,7 @@ static void __lru_cache_add(struct page *page) | |||
411 | } | 411 | } |
412 | 412 | ||
413 | /** | 413 | /** |
414 | * lru_cache_add: add a page to the page lists | 414 | * lru_cache_add_anon - add a page to the page lists |
415 | * @page: the page to add | 415 | * @page: the page to add |
416 | */ | 416 | */ |
417 | void lru_cache_add_anon(struct page *page) | 417 | void lru_cache_add_anon(struct page *page) |
@@ -930,10 +930,10 @@ EXPORT_SYMBOL(__pagevec_lru_add); | |||
930 | */ | 930 | */ |
931 | unsigned pagevec_lookup_entries(struct pagevec *pvec, | 931 | unsigned pagevec_lookup_entries(struct pagevec *pvec, |
932 | struct address_space *mapping, | 932 | struct address_space *mapping, |
933 | pgoff_t start, unsigned nr_pages, | 933 | pgoff_t start, unsigned nr_entries, |
934 | pgoff_t *indices) | 934 | pgoff_t *indices) |
935 | { | 935 | { |
936 | pvec->nr = find_get_entries(mapping, start, nr_pages, | 936 | pvec->nr = find_get_entries(mapping, start, nr_entries, |
937 | pvec->pages, indices); | 937 | pvec->pages, indices); |
938 | return pagevec_count(pvec); | 938 | return pagevec_count(pvec); |
939 | } | 939 | } |
@@ -965,9 +965,8 @@ void pagevec_remove_exceptionals(struct pagevec *pvec) | |||
965 | * @mapping: The address_space to search | 965 | * @mapping: The address_space to search |
966 | * @start: The starting page index | 966 | * @start: The starting page index |
967 | * @end: The final page index | 967 | * @end: The final page index |
968 | * @nr_pages: The maximum number of pages | ||
969 | * | 968 | * |
970 | * pagevec_lookup_range() will search for and return a group of up to @nr_pages | 969 | * pagevec_lookup_range() will search for & return a group of up to PAGEVEC_SIZE |
971 | * pages in the mapping starting from index @start and upto index @end | 970 | * pages in the mapping starting from index @start and upto index @end |
972 | * (inclusive). The pages are placed in @pvec. pagevec_lookup() takes a | 971 | * (inclusive). The pages are placed in @pvec. pagevec_lookup() takes a |
973 | * reference against the pages in @pvec. | 972 | * reference against the pages in @pvec. |
@@ -977,7 +976,7 @@ void pagevec_remove_exceptionals(struct pagevec *pvec) | |||
977 | * also update @start to index the next page for the traversal. | 976 | * also update @start to index the next page for the traversal. |
978 | * | 977 | * |
979 | * pagevec_lookup_range() returns the number of pages which were found. If this | 978 | * pagevec_lookup_range() returns the number of pages which were found. If this |
980 | * number is smaller than @nr_pages, the end of specified range has been | 979 | * number is smaller than PAGEVEC_SIZE, the end of specified range has been |
981 | * reached. | 980 | * reached. |
982 | */ | 981 | */ |
983 | unsigned pagevec_lookup_range(struct pagevec *pvec, | 982 | unsigned pagevec_lookup_range(struct pagevec *pvec, |