diff options
author | Dhinakaran Pandiyan <dhinakaran.pandiyan@gmail.com> | 2017-12-19 23:35:20 -0500 |
---|---|---|
committer | Jani Nikula <jani.nikula@intel.com> | 2018-01-02 06:44:56 -0500 |
commit | e0093a89f2386f12cc87047b43e93c3c6e15e94e (patch) | |
tree | 644d555883200da4d95251ceb2fb62e12b1330e7 | |
parent | 30a7acd573899fd8b8ac39236eff6468b195ac7d (diff) |
drm/i915/psr: Fix register name mess up.
Commit 77affa31722b ("drm/i915/psr: Fix compiler warnings for
hsw_psr_disable()") swapped status and control registers while fixing
indentation. The _ctl at the end of the status register name must have to
led to this.
Fixes: 77affa31722b ("drm/i915/psr: Fix compiler warnings for hsw_psr_disable()")
References: https://www.mrc-cbu.cam.ac.uk/people/matt.davis/cmabridge/
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171220043520.2599-1-dhinakaran.pandiyan@intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
(cherry picked from commit 14c6547d6df641d3e41fa4f4164f6e267ebfab89)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
-rw-r--r-- | drivers/gpu/drm/i915/intel_psr.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index 6e3b430fccdc..55ea5eb3b7df 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c | |||
@@ -590,7 +590,7 @@ static void hsw_psr_disable(struct intel_dp *intel_dp, | |||
590 | struct drm_i915_private *dev_priv = to_i915(dev); | 590 | struct drm_i915_private *dev_priv = to_i915(dev); |
591 | 591 | ||
592 | if (dev_priv->psr.active) { | 592 | if (dev_priv->psr.active) { |
593 | i915_reg_t psr_ctl; | 593 | i915_reg_t psr_status; |
594 | u32 psr_status_mask; | 594 | u32 psr_status_mask; |
595 | 595 | ||
596 | if (dev_priv->psr.aux_frame_sync) | 596 | if (dev_priv->psr.aux_frame_sync) |
@@ -599,24 +599,24 @@ static void hsw_psr_disable(struct intel_dp *intel_dp, | |||
599 | 0); | 599 | 0); |
600 | 600 | ||
601 | if (dev_priv->psr.psr2_support) { | 601 | if (dev_priv->psr.psr2_support) { |
602 | psr_ctl = EDP_PSR2_CTL; | 602 | psr_status = EDP_PSR2_STATUS_CTL; |
603 | psr_status_mask = EDP_PSR2_STATUS_STATE_MASK; | 603 | psr_status_mask = EDP_PSR2_STATUS_STATE_MASK; |
604 | 604 | ||
605 | I915_WRITE(psr_ctl, | 605 | I915_WRITE(EDP_PSR2_CTL, |
606 | I915_READ(psr_ctl) & | 606 | I915_READ(EDP_PSR2_CTL) & |
607 | ~(EDP_PSR2_ENABLE | EDP_SU_TRACK_ENABLE)); | 607 | ~(EDP_PSR2_ENABLE | EDP_SU_TRACK_ENABLE)); |
608 | 608 | ||
609 | } else { | 609 | } else { |
610 | psr_ctl = EDP_PSR_STATUS_CTL; | 610 | psr_status = EDP_PSR_STATUS_CTL; |
611 | psr_status_mask = EDP_PSR_STATUS_STATE_MASK; | 611 | psr_status_mask = EDP_PSR_STATUS_STATE_MASK; |
612 | 612 | ||
613 | I915_WRITE(psr_ctl, | 613 | I915_WRITE(EDP_PSR_CTL, |
614 | I915_READ(psr_ctl) & ~EDP_PSR_ENABLE); | 614 | I915_READ(EDP_PSR_CTL) & ~EDP_PSR_ENABLE); |
615 | } | 615 | } |
616 | 616 | ||
617 | /* Wait till PSR is idle */ | 617 | /* Wait till PSR is idle */ |
618 | if (intel_wait_for_register(dev_priv, | 618 | if (intel_wait_for_register(dev_priv, |
619 | psr_ctl, psr_status_mask, 0, | 619 | psr_status, psr_status_mask, 0, |
620 | 2000)) | 620 | 2000)) |
621 | DRM_ERROR("Timed out waiting for PSR Idle State\n"); | 621 | DRM_ERROR("Timed out waiting for PSR Idle State\n"); |
622 | 622 | ||