aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2018-09-12 20:48:02 -0400
committerTomi Valkeinen <tomi.valkeinen@ti.com>2019-03-18 05:42:12 -0400
commitdf6682b43533e4c59c3d14b56de838c035a8bb9a (patch)
treea2cc141dceeacbfaf716bb6c970b3fad8b485073
parent27a7e3e18419869cdcc414a404f3fe66f1b4e644 (diff)
drm/omap: Remove src field from omap_dss_device structure
The field is only used to check whether the device is connected, and we can do so by checking the dss field instead. Remove the src field. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
-rw-r--r--drivers/gpu/drm/omapdrm/dss/base.c14
-rw-r--r--drivers/gpu/drm/omapdrm/dss/omapdss.h1
2 files changed, 1 insertions, 14 deletions
diff --git a/drivers/gpu/drm/omapdrm/dss/base.c b/drivers/gpu/drm/omapdrm/dss/base.c
index 76470ba45660..62ccbeb99a84 100644
--- a/drivers/gpu/drm/omapdrm/dss/base.c
+++ b/drivers/gpu/drm/omapdrm/dss/base.c
@@ -176,7 +176,7 @@ EXPORT_SYMBOL(omapdss_device_next_output);
176 176
177static bool omapdss_device_is_connected(struct omap_dss_device *dssdev) 177static bool omapdss_device_is_connected(struct omap_dss_device *dssdev)
178{ 178{
179 return dssdev->src; 179 return dssdev->dss;
180} 180}
181 181
182int omapdss_device_connect(struct dss_device *dss, 182int omapdss_device_connect(struct dss_device *dss,
@@ -198,11 +198,6 @@ int omapdss_device_connect(struct dss_device *dss,
198 return ret; 198 return ret;
199 } 199 }
200 200
201 if (src) {
202 WARN_ON(dst->src);
203 dst->src = src;
204 }
205
206 return 0; 201 return 0;
207} 202}
208EXPORT_SYMBOL_GPL(omapdss_device_connect); 203EXPORT_SYMBOL_GPL(omapdss_device_connect);
@@ -217,13 +212,6 @@ void omapdss_device_disconnect(struct omap_dss_device *src,
217 return; 212 return;
218 } 213 }
219 214
220 if (src) {
221 if (WARN_ON(dst->src != src))
222 return;
223
224 dst->src = NULL;
225 }
226
227 WARN_ON(dst->state != OMAP_DSS_DISPLAY_DISABLED); 215 WARN_ON(dst->state != OMAP_DSS_DISPLAY_DISABLED);
228 216
229 dst->ops->disconnect(src, dst); 217 dst->ops->disconnect(src, dst);
diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
index dd93c2121a35..015b2dd9fb99 100644
--- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
+++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
@@ -409,7 +409,6 @@ struct omap_dss_device {
409 struct module *owner; 409 struct module *owner;
410 410
411 struct dss_device *dss; 411 struct dss_device *dss;
412 struct omap_dss_device *src;
413 struct omap_dss_device *next; 412 struct omap_dss_device *next;
414 413
415 struct list_head list; 414 struct list_head list;