aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDominik Brodowski <linux@dominikbrodowski.net>2018-03-19 12:32:11 -0400
committerDominik Brodowski <linux@dominikbrodowski.net>2018-04-02 14:16:08 -0400
commitdf260e21e6cd5d2dfc1fe9b6a3bbf747e72b3bed (patch)
tree8731b85570ffef662667b01e33769f9d9d2c2baa
parent806cbae1228cc1a19b978c4513f6851e9ab7f388 (diff)
fs: add ksys_truncate() wrapper; remove in-kernel calls to sys_truncate()
Using the ksys_truncate() wrapper allows us to get rid of in-kernel calls to the sys_truncate() syscall. The ksys_ prefix denotes that this function is meant as a drop-in replacement for the syscall. In particular, it uses the same calling convention as sys_truncate(). This patch is part of a series which removes in-kernel calls to syscalls. On this basis, the syscall entry path can be streamlined. For details, see http://lkml.kernel.org/r/20180325162527.GA17492@light.dominikbrodowski.net Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
-rw-r--r--arch/mips/kernel/linux32.c2
-rw-r--r--arch/parisc/kernel/sys_parisc.c6
-rw-r--r--arch/powerpc/kernel/sys_ppc32.c2
-rw-r--r--arch/s390/kernel/compat_linux.c2
-rw-r--r--arch/sparc/kernel/sys_sparc32.c2
-rw-r--r--arch/x86/ia32/sys_ia32.c3
-rw-r--r--fs/open.c2
-rw-r--r--include/linux/syscalls.h7
8 files changed, 17 insertions, 9 deletions
diff --git a/arch/mips/kernel/linux32.c b/arch/mips/kernel/linux32.c
index 57b3310873f0..58e7dd27f106 100644
--- a/arch/mips/kernel/linux32.c
+++ b/arch/mips/kernel/linux32.c
@@ -82,7 +82,7 @@ struct rlimit32 {
82SYSCALL_DEFINE4(32_truncate64, const char __user *, path, 82SYSCALL_DEFINE4(32_truncate64, const char __user *, path,
83 unsigned long, __dummy, unsigned long, a2, unsigned long, a3) 83 unsigned long, __dummy, unsigned long, a2, unsigned long, a3)
84{ 84{
85 return sys_truncate(path, merge_64(a2, a3)); 85 return ksys_truncate(path, merge_64(a2, a3));
86} 86}
87 87
88SYSCALL_DEFINE4(32_ftruncate64, unsigned long, fd, unsigned long, __dummy, 88SYSCALL_DEFINE4(32_ftruncate64, unsigned long, fd, unsigned long, __dummy,
diff --git a/arch/parisc/kernel/sys_parisc.c b/arch/parisc/kernel/sys_parisc.c
index ef995b5d97ef..3377a00163c3 100644
--- a/arch/parisc/kernel/sys_parisc.c
+++ b/arch/parisc/kernel/sys_parisc.c
@@ -292,7 +292,7 @@ asmlinkage unsigned long sys_mmap(unsigned long addr, unsigned long len,
292asmlinkage long parisc_truncate64(const char __user * path, 292asmlinkage long parisc_truncate64(const char __user * path,
293 unsigned int high, unsigned int low) 293 unsigned int high, unsigned int low)
294{ 294{
295 return sys_truncate(path, (long)high << 32 | low); 295 return ksys_truncate(path, (long)high << 32 | low);
296} 296}
297 297
298asmlinkage long parisc_ftruncate64(unsigned int fd, 298asmlinkage long parisc_ftruncate64(unsigned int fd,
@@ -305,7 +305,7 @@ asmlinkage long parisc_ftruncate64(unsigned int fd,
305 * are identical on LP64 */ 305 * are identical on LP64 */
306asmlinkage long sys_truncate64(const char __user * path, unsigned long length) 306asmlinkage long sys_truncate64(const char __user * path, unsigned long length)
307{ 307{
308 return sys_truncate(path, length); 308 return ksys_truncate(path, length);
309} 309}
310asmlinkage long sys_ftruncate64(unsigned int fd, unsigned long length) 310asmlinkage long sys_ftruncate64(unsigned int fd, unsigned long length)
311{ 311{
@@ -320,7 +320,7 @@ asmlinkage long sys_fcntl64(unsigned int fd, unsigned int cmd, unsigned long arg
320asmlinkage long parisc_truncate64(const char __user * path, 320asmlinkage long parisc_truncate64(const char __user * path,
321 unsigned int high, unsigned int low) 321 unsigned int high, unsigned int low)
322{ 322{
323 return sys_truncate64(path, (loff_t)high << 32 | low); 323 return ksys_truncate(path, (loff_t)high << 32 | low);
324} 324}
325 325
326asmlinkage long parisc_ftruncate64(unsigned int fd, 326asmlinkage long parisc_ftruncate64(unsigned int fd,
diff --git a/arch/powerpc/kernel/sys_ppc32.c b/arch/powerpc/kernel/sys_ppc32.c
index 664e4c5b5855..a0a251d7c9c5 100644
--- a/arch/powerpc/kernel/sys_ppc32.c
+++ b/arch/powerpc/kernel/sys_ppc32.c
@@ -94,7 +94,7 @@ compat_ssize_t compat_sys_readahead(int fd, u32 r4, u32 offhi, u32 offlo, u32 co
94asmlinkage int compat_sys_truncate64(const char __user * path, u32 reg4, 94asmlinkage int compat_sys_truncate64(const char __user * path, u32 reg4,
95 unsigned long high, unsigned long low) 95 unsigned long high, unsigned long low)
96{ 96{
97 return sys_truncate(path, (high << 32) | low); 97 return ksys_truncate(path, (high << 32) | low);
98} 98}
99 99
100asmlinkage long compat_sys_fallocate(int fd, int mode, u32 offhi, u32 offlo, 100asmlinkage long compat_sys_fallocate(int fd, int mode, u32 offhi, u32 offlo,
diff --git a/arch/s390/kernel/compat_linux.c b/arch/s390/kernel/compat_linux.c
index 605f6f026e44..e4092ec17ea5 100644
--- a/arch/s390/kernel/compat_linux.c
+++ b/arch/s390/kernel/compat_linux.c
@@ -302,7 +302,7 @@ COMPAT_SYSCALL_DEFINE5(s390_ipc, uint, call, int, first, compat_ulong_t, second,
302 302
303COMPAT_SYSCALL_DEFINE3(s390_truncate64, const char __user *, path, u32, high, u32, low) 303COMPAT_SYSCALL_DEFINE3(s390_truncate64, const char __user *, path, u32, high, u32, low)
304{ 304{
305 return sys_truncate(path, (unsigned long)high << 32 | low); 305 return ksys_truncate(path, (unsigned long)high << 32 | low);
306} 306}
307 307
308COMPAT_SYSCALL_DEFINE3(s390_ftruncate64, unsigned int, fd, u32, high, u32, low) 308COMPAT_SYSCALL_DEFINE3(s390_ftruncate64, unsigned int, fd, u32, high, u32, low)
diff --git a/arch/sparc/kernel/sys_sparc32.c b/arch/sparc/kernel/sys_sparc32.c
index af18b9ff86be..aab2428b17b5 100644
--- a/arch/sparc/kernel/sys_sparc32.c
+++ b/arch/sparc/kernel/sys_sparc32.c
@@ -57,7 +57,7 @@ asmlinkage long sys32_truncate64(const char __user * path, unsigned long high, u
57 if ((int)high < 0) 57 if ((int)high < 0)
58 return -EINVAL; 58 return -EINVAL;
59 else 59 else
60 return sys_truncate(path, (high << 32) | low); 60 return ksys_truncate(path, (high << 32) | low);
61} 61}
62 62
63asmlinkage long sys32_ftruncate64(unsigned int fd, unsigned long high, unsigned long low) 63asmlinkage long sys32_ftruncate64(unsigned int fd, unsigned long high, unsigned long low)
diff --git a/arch/x86/ia32/sys_ia32.c b/arch/x86/ia32/sys_ia32.c
index 0c5f8932c136..90e7a2b3dc5b 100644
--- a/arch/x86/ia32/sys_ia32.c
+++ b/arch/x86/ia32/sys_ia32.c
@@ -55,7 +55,8 @@
55COMPAT_SYSCALL_DEFINE3(x86_truncate64, const char __user *, filename, 55COMPAT_SYSCALL_DEFINE3(x86_truncate64, const char __user *, filename,
56 unsigned long, offset_low, unsigned long, offset_high) 56 unsigned long, offset_low, unsigned long, offset_high)
57{ 57{
58 return sys_truncate(filename, ((loff_t) offset_high << 32) | offset_low); 58 return ksys_truncate(filename,
59 ((loff_t) offset_high << 32) | offset_low);
59} 60}
60 61
61COMPAT_SYSCALL_DEFINE3(x86_ftruncate64, unsigned int, fd, 62COMPAT_SYSCALL_DEFINE3(x86_ftruncate64, unsigned int, fd,
diff --git a/fs/open.c b/fs/open.c
index 8a42a2961130..2e816fc7bd56 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -128,7 +128,7 @@ out:
128} 128}
129EXPORT_SYMBOL_GPL(vfs_truncate); 129EXPORT_SYMBOL_GPL(vfs_truncate);
130 130
131static long do_sys_truncate(const char __user *pathname, loff_t length) 131long do_sys_truncate(const char __user *pathname, loff_t length)
132{ 132{
133 unsigned int lookup_flags = LOOKUP_FOLLOW; 133 unsigned int lookup_flags = LOOKUP_FOLLOW;
134 struct path path; 134 struct path path;
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 331da76f66e2..78b79e3a1279 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -1078,4 +1078,11 @@ static inline long ksys_open(const char __user *filename, int flags,
1078 return do_sys_open(AT_FDCWD, filename, flags, mode); 1078 return do_sys_open(AT_FDCWD, filename, flags, mode);
1079} 1079}
1080 1080
1081extern long do_sys_truncate(const char __user *pathname, loff_t length);
1082
1083static inline long ksys_truncate(const char __user *pathname, loff_t length)
1084{
1085 return do_sys_truncate(pathname, length);
1086}
1087
1081#endif 1088#endif