diff options
author | Josh Poimboeuf <jpoimboe@redhat.com> | 2017-07-27 16:56:55 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2017-08-21 10:07:27 -0400 |
commit | deecd4d71b12626db48544faa66bb897e2cafd07 (patch) | |
tree | fb351bffbae38eec99a99b63bec7a2c3039d172d | |
parent | 14ccee78fc82f5512908f4424f541549a5705b89 (diff) |
objtool: Fix '-mtune=atom' decoding support in objtool 2.0
With '-mtune=atom', which is enabled with CONFIG_MATOM=y, GCC uses some
unusual instructions for setting up the stack.
Instead of:
mov %rsp, %rbp
it does:
lea (%rsp), %rbp
And instead of:
add imm, %rsp
it does:
lea disp(%rsp), %rsp
Add support for these instructions to the objtool decoder.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: baa41469a7b9 ("objtool: Implement stack validation 2.0")
Link: http://lkml.kernel.org/r/4ea1db896e821226efe1f8e09f270771bde47e65.1501188854.git.jpoimboe@redhat.com
[ This is a cherry-picked version of upcoming commit 5b8de48e82ba. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | tools/objtool/arch/x86/decode.c | 26 |
1 files changed, 25 insertions, 1 deletions
diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c index a36c2eba64e7..4559a21a8de2 100644 --- a/tools/objtool/arch/x86/decode.c +++ b/tools/objtool/arch/x86/decode.c | |||
@@ -271,7 +271,7 @@ int arch_decode_instruction(struct elf *elf, struct section *sec, | |||
271 | case 0x8d: | 271 | case 0x8d: |
272 | if (rex == 0x48 && modrm == 0x65) { | 272 | if (rex == 0x48 && modrm == 0x65) { |
273 | 273 | ||
274 | /* lea -disp(%rbp), %rsp */ | 274 | /* lea disp(%rbp), %rsp */ |
275 | *type = INSN_STACK; | 275 | *type = INSN_STACK; |
276 | op->src.type = OP_SRC_ADD; | 276 | op->src.type = OP_SRC_ADD; |
277 | op->src.reg = CFI_BP; | 277 | op->src.reg = CFI_BP; |
@@ -281,6 +281,30 @@ int arch_decode_instruction(struct elf *elf, struct section *sec, | |||
281 | break; | 281 | break; |
282 | } | 282 | } |
283 | 283 | ||
284 | if (rex == 0x48 && (modrm == 0xa4 || modrm == 0x64) && | ||
285 | sib == 0x24) { | ||
286 | |||
287 | /* lea disp(%rsp), %rsp */ | ||
288 | *type = INSN_STACK; | ||
289 | op->src.type = OP_SRC_ADD; | ||
290 | op->src.reg = CFI_SP; | ||
291 | op->src.offset = insn.displacement.value; | ||
292 | op->dest.type = OP_DEST_REG; | ||
293 | op->dest.reg = CFI_SP; | ||
294 | break; | ||
295 | } | ||
296 | |||
297 | if (rex == 0x48 && modrm == 0x2c && sib == 0x24) { | ||
298 | |||
299 | /* lea (%rsp), %rbp */ | ||
300 | *type = INSN_STACK; | ||
301 | op->src.type = OP_SRC_REG; | ||
302 | op->src.reg = CFI_SP; | ||
303 | op->dest.type = OP_DEST_REG; | ||
304 | op->dest.reg = CFI_BP; | ||
305 | break; | ||
306 | } | ||
307 | |||
284 | if (rex == 0x4c && modrm == 0x54 && sib == 0x24 && | 308 | if (rex == 0x4c && modrm == 0x54 && sib == 0x24 && |
285 | insn.displacement.value == 8) { | 309 | insn.displacement.value == 8) { |
286 | 310 | ||