diff options
author | Fabio Estevam <fabio.estevam@nxp.com> | 2016-07-09 17:57:42 -0400 |
---|---|---|
committer | Philipp Zabel <p.zabel@pengutronix.de> | 2016-07-12 12:24:30 -0400 |
commit | deb65870b5d9d939bb319661dd489272a6de665d (patch) | |
tree | 5bc0a75230cce19cd5073ea2e82cadbc6c0c8123 | |
parent | 7075ba7942b80704588cc60bce945519b0302ced (diff) |
drm/imx: imx-tve: check the value returned by regulator_set_voltage()
regulator_set_voltage() may fail, so we better check its return value
and propagate it in the case of error.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
-rw-r--r-- | drivers/gpu/drm/imx/imx-tve.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index a293a7dad0d9..fe36309e18c1 100644 --- a/drivers/gpu/drm/imx/imx-tve.c +++ b/drivers/gpu/drm/imx/imx-tve.c | |||
@@ -628,7 +628,9 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data) | |||
628 | 628 | ||
629 | tve->dac_reg = devm_regulator_get(dev, "dac"); | 629 | tve->dac_reg = devm_regulator_get(dev, "dac"); |
630 | if (!IS_ERR(tve->dac_reg)) { | 630 | if (!IS_ERR(tve->dac_reg)) { |
631 | regulator_set_voltage(tve->dac_reg, 2750000, 2750000); | 631 | ret = regulator_set_voltage(tve->dac_reg, 2750000, 2750000); |
632 | if (ret) | ||
633 | return ret; | ||
632 | ret = regulator_enable(tve->dac_reg); | 634 | ret = regulator_enable(tve->dac_reg); |
633 | if (ret) | 635 | if (ret) |
634 | return ret; | 636 | return ret; |