diff options
author | Shawn Guo <shawn.guo@linaro.org> | 2017-02-20 08:49:11 -0500 |
---|---|---|
committer | Shawn Guo <shawn.guo@linaro.org> | 2017-02-22 19:54:15 -0500 |
commit | dc5e1d628a7bb631450ea661553a8bb496891f47 (patch) | |
tree | ab0b5e595a84097e6e979aae849e1dfedfee4a7e | |
parent | 2220fc1ab363e6fab1f321430d69be17a8b92bd7 (diff) |
drm: zte: fix static checker warning on variable 'fmt'
Commit 4e986d3705df ("drm: zte: add overlay plane support") introduces
the following static checker warning:
drivers/gpu/drm/zte/zx_plane.c:170 zx_vl_rsz_setup()
warn: always true condition '(fmt >= 0) => (0-u32max >= 0)'
Fix it by change 'fmt' type to integer.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 4e986d3705df ("drm: zte: add overlay plane support")
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Link: http://patchwork.freedesktop.org/patch/msgid/1487598551-28310-1-git-send-email-shawnguo@kernel.org
-rw-r--r-- | drivers/gpu/drm/zte/zx_plane.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/zte/zx_plane.c b/drivers/gpu/drm/zte/zx_plane.c index 1d08ba381098..d646ac931663 100644 --- a/drivers/gpu/drm/zte/zx_plane.c +++ b/drivers/gpu/drm/zte/zx_plane.c | |||
@@ -159,7 +159,7 @@ static void zx_vl_rsz_setup(struct zx_plane *zplane, uint32_t format, | |||
159 | void __iomem *rsz = zplane->rsz; | 159 | void __iomem *rsz = zplane->rsz; |
160 | u32 src_chroma_w = src_w; | 160 | u32 src_chroma_w = src_w; |
161 | u32 src_chroma_h = src_h; | 161 | u32 src_chroma_h = src_h; |
162 | u32 fmt; | 162 | int fmt; |
163 | 163 | ||
164 | /* Set up source and destination resolution */ | 164 | /* Set up source and destination resolution */ |
165 | zx_writel(rsz + RSZ_SRC_CFG, RSZ_VER(src_h - 1) | RSZ_HOR(src_w - 1)); | 165 | zx_writel(rsz + RSZ_SRC_CFG, RSZ_VER(src_h - 1) | RSZ_HOR(src_w - 1)); |
@@ -203,7 +203,7 @@ static void zx_vl_plane_atomic_update(struct drm_plane *plane, | |||
203 | u32 src_x, src_y, src_w, src_h; | 203 | u32 src_x, src_y, src_w, src_h; |
204 | u32 dst_x, dst_y, dst_w, dst_h; | 204 | u32 dst_x, dst_y, dst_w, dst_h; |
205 | uint32_t format; | 205 | uint32_t format; |
206 | u32 fmt; | 206 | int fmt; |
207 | int num_planes; | 207 | int num_planes; |
208 | int i; | 208 | int i; |
209 | 209 | ||