diff options
author | Dirk Mueller <dmueller@suse.com> | 2018-07-25 07:10:28 -0400 |
---|---|---|
committer | Will Deacon <will.deacon@arm.com> | 2018-07-25 08:30:04 -0400 |
commit | dc0e36581eb2da1aa3c63ceeff0f10ef1e899b2a (patch) | |
tree | 174058c852b242e815e9082183e9122811abec5f | |
parent | d72e90f33aa4709ebecc5005562f52335e106a60 (diff) |
arm64: Check for errata before evaluating cpu features
Since commit d3aec8a28be3b8 ("arm64: capabilities: Restrict KPTI
detection to boot-time CPUs") we rely on errata flags being already
populated during feature enumeration. The order of errata and
features was flipped as part of commit ed478b3f9e4a ("arm64:
capabilities: Group handling of features and errata workarounds").
Return to the orginal order of errata and feature evaluation to
ensure errata flags are present during feature evaluation.
Fixes: ed478b3f9e4a ("arm64: capabilities: Group handling of
features and errata workarounds")
CC: Suzuki K Poulose <suzuki.poulose@arm.com>
CC: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Dirk Mueller <dmueller@suse.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
-rw-r--r-- | arch/arm64/kernel/cpufeature.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index f24892a40d2c..c6d80743f4ed 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c | |||
@@ -1351,9 +1351,9 @@ static void __update_cpu_capabilities(const struct arm64_cpu_capabilities *caps, | |||
1351 | 1351 | ||
1352 | static void update_cpu_capabilities(u16 scope_mask) | 1352 | static void update_cpu_capabilities(u16 scope_mask) |
1353 | { | 1353 | { |
1354 | __update_cpu_capabilities(arm64_features, scope_mask, "detected:"); | ||
1355 | __update_cpu_capabilities(arm64_errata, scope_mask, | 1354 | __update_cpu_capabilities(arm64_errata, scope_mask, |
1356 | "enabling workaround for"); | 1355 | "enabling workaround for"); |
1356 | __update_cpu_capabilities(arm64_features, scope_mask, "detected:"); | ||
1357 | } | 1357 | } |
1358 | 1358 | ||
1359 | static int __enable_cpu_capability(void *arg) | 1359 | static int __enable_cpu_capability(void *arg) |
@@ -1408,8 +1408,8 @@ __enable_cpu_capabilities(const struct arm64_cpu_capabilities *caps, | |||
1408 | 1408 | ||
1409 | static void __init enable_cpu_capabilities(u16 scope_mask) | 1409 | static void __init enable_cpu_capabilities(u16 scope_mask) |
1410 | { | 1410 | { |
1411 | __enable_cpu_capabilities(arm64_features, scope_mask); | ||
1412 | __enable_cpu_capabilities(arm64_errata, scope_mask); | 1411 | __enable_cpu_capabilities(arm64_errata, scope_mask); |
1412 | __enable_cpu_capabilities(arm64_features, scope_mask); | ||
1413 | } | 1413 | } |
1414 | 1414 | ||
1415 | /* | 1415 | /* |