diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-07-15 07:06:30 -0400 |
---|---|---|
committer | Brian Norris <computersforpeace@gmail.com> | 2016-07-15 21:40:25 -0400 |
commit | dc01a28d80a42cef08c94dfc595565aaebe46d15 (patch) | |
tree | d40529045d5a1cfcc3301ef37bcb2016485894b1 | |
parent | 161aaab8a067a96b686e2429a72bfd92f6aaf363 (diff) |
mtd: maps: sa1100-flash: potential NULL dereference
We check for NULL but then dereference "info->mtd" on the next line.
Fixes: 72169755cf36 ('mtd: maps: sa1100-flash: show parent device in sysfs')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
-rw-r--r-- | drivers/mtd/maps/sa1100-flash.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mtd/maps/sa1100-flash.c b/drivers/mtd/maps/sa1100-flash.c index 142fc3d79463..784c6e1a0391 100644 --- a/drivers/mtd/maps/sa1100-flash.c +++ b/drivers/mtd/maps/sa1100-flash.c | |||
@@ -230,8 +230,10 @@ static struct sa_info *sa1100_setup_mtd(struct platform_device *pdev, | |||
230 | 230 | ||
231 | info->mtd = mtd_concat_create(cdev, info->num_subdev, | 231 | info->mtd = mtd_concat_create(cdev, info->num_subdev, |
232 | plat->name); | 232 | plat->name); |
233 | if (info->mtd == NULL) | 233 | if (info->mtd == NULL) { |
234 | ret = -ENXIO; | 234 | ret = -ENXIO; |
235 | goto err; | ||
236 | } | ||
235 | } | 237 | } |
236 | info->mtd->dev.parent = &pdev->dev; | 238 | info->mtd->dev.parent = &pdev->dev; |
237 | 239 | ||