diff options
author | Rob Clark <robdclark@gmail.com> | 2017-10-16 13:35:57 -0400 |
---|---|---|
committer | Rob Clark <robdclark@gmail.com> | 2017-10-28 11:01:33 -0400 |
commit | db9a3750eb6fec2381b4090b4f10e56fafe512fe (patch) | |
tree | 532b79076608ddcb17c095e9e133e7baaedfe321 | |
parent | e9acce2bb94c1db47fd0463c8d16ba9794111ca5 (diff) |
drm/msm/dsi: convert to msm_clk_get()
We already have, as a result of upstreaming the gpu bindings,
msm_clk_get() which will try to get the clock both without and with a
"_clk" suffix. Use this in DSI code so we can drop the "_clk" suffix
in bindings while maintaing backwards compatibility.
Signed-off-by: Rob Clark <robdclark@gmail.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
-rw-r--r-- | drivers/gpu/drm/msm/dsi/dsi_cfg.c | 8 | ||||
-rw-r--r-- | drivers/gpu/drm/msm/dsi/dsi_host.c | 30 | ||||
-rw-r--r-- | drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 |
3 files changed, 20 insertions, 20 deletions
diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c index a5d75c9b3a73..65c1dfbbe019 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c | |||
@@ -14,7 +14,7 @@ | |||
14 | #include "dsi_cfg.h" | 14 | #include "dsi_cfg.h" |
15 | 15 | ||
16 | static const char * const dsi_v2_bus_clk_names[] = { | 16 | static const char * const dsi_v2_bus_clk_names[] = { |
17 | "core_mmss_clk", "iface_clk", "bus_clk", | 17 | "core_mmss", "iface", "bus", |
18 | }; | 18 | }; |
19 | 19 | ||
20 | static const struct msm_dsi_config apq8064_dsi_cfg = { | 20 | static const struct msm_dsi_config apq8064_dsi_cfg = { |
@@ -34,7 +34,7 @@ static const struct msm_dsi_config apq8064_dsi_cfg = { | |||
34 | }; | 34 | }; |
35 | 35 | ||
36 | static const char * const dsi_6g_bus_clk_names[] = { | 36 | static const char * const dsi_6g_bus_clk_names[] = { |
37 | "mdp_core_clk", "iface_clk", "bus_clk", "core_mmss_clk", | 37 | "mdp_core", "iface", "bus", "core_mmss", |
38 | }; | 38 | }; |
39 | 39 | ||
40 | static const struct msm_dsi_config msm8974_apq8084_dsi_cfg = { | 40 | static const struct msm_dsi_config msm8974_apq8084_dsi_cfg = { |
@@ -55,7 +55,7 @@ static const struct msm_dsi_config msm8974_apq8084_dsi_cfg = { | |||
55 | }; | 55 | }; |
56 | 56 | ||
57 | static const char * const dsi_8916_bus_clk_names[] = { | 57 | static const char * const dsi_8916_bus_clk_names[] = { |
58 | "mdp_core_clk", "iface_clk", "bus_clk", | 58 | "mdp_core", "iface", "bus", |
59 | }; | 59 | }; |
60 | 60 | ||
61 | static const struct msm_dsi_config msm8916_dsi_cfg = { | 61 | static const struct msm_dsi_config msm8916_dsi_cfg = { |
@@ -99,7 +99,7 @@ static const struct msm_dsi_config msm8994_dsi_cfg = { | |||
99 | * without it too. Figure out why it doesn't enable and uncomment below | 99 | * without it too. Figure out why it doesn't enable and uncomment below |
100 | */ | 100 | */ |
101 | static const char * const dsi_8996_bus_clk_names[] = { | 101 | static const char * const dsi_8996_bus_clk_names[] = { |
102 | "mdp_core_clk", "iface_clk", "bus_clk", /* "core_mmss_clk", */ | 102 | "mdp_core", "iface", "bus", /* "core_mmss", */ |
103 | }; | 103 | }; |
104 | 104 | ||
105 | static const struct msm_dsi_config msm8996_dsi_cfg = { | 105 | static const struct msm_dsi_config msm8996_dsi_cfg = { |
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index dbb31a014419..50d437568d43 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c | |||
@@ -334,46 +334,46 @@ static int dsi_regulator_init(struct msm_dsi_host *msm_host) | |||
334 | 334 | ||
335 | static int dsi_clk_init(struct msm_dsi_host *msm_host) | 335 | static int dsi_clk_init(struct msm_dsi_host *msm_host) |
336 | { | 336 | { |
337 | struct device *dev = &msm_host->pdev->dev; | 337 | struct platform_device *pdev = msm_host->pdev; |
338 | const struct msm_dsi_cfg_handler *cfg_hnd = msm_host->cfg_hnd; | 338 | const struct msm_dsi_cfg_handler *cfg_hnd = msm_host->cfg_hnd; |
339 | const struct msm_dsi_config *cfg = cfg_hnd->cfg; | 339 | const struct msm_dsi_config *cfg = cfg_hnd->cfg; |
340 | int i, ret = 0; | 340 | int i, ret = 0; |
341 | 341 | ||
342 | /* get bus clocks */ | 342 | /* get bus clocks */ |
343 | for (i = 0; i < cfg->num_bus_clks; i++) { | 343 | for (i = 0; i < cfg->num_bus_clks; i++) { |
344 | msm_host->bus_clks[i] = devm_clk_get(dev, | 344 | msm_host->bus_clks[i] = msm_clk_get(pdev, |
345 | cfg->bus_clk_names[i]); | 345 | cfg->bus_clk_names[i]); |
346 | if (IS_ERR(msm_host->bus_clks[i])) { | 346 | if (IS_ERR(msm_host->bus_clks[i])) { |
347 | ret = PTR_ERR(msm_host->bus_clks[i]); | 347 | ret = PTR_ERR(msm_host->bus_clks[i]); |
348 | pr_err("%s: Unable to get %s, ret = %d\n", | 348 | pr_err("%s: Unable to get %s clock, ret = %d\n", |
349 | __func__, cfg->bus_clk_names[i], ret); | 349 | __func__, cfg->bus_clk_names[i], ret); |
350 | goto exit; | 350 | goto exit; |
351 | } | 351 | } |
352 | } | 352 | } |
353 | 353 | ||
354 | /* get link and source clocks */ | 354 | /* get link and source clocks */ |
355 | msm_host->byte_clk = devm_clk_get(dev, "byte_clk"); | 355 | msm_host->byte_clk = msm_clk_get(pdev, "byte"); |
356 | if (IS_ERR(msm_host->byte_clk)) { | 356 | if (IS_ERR(msm_host->byte_clk)) { |
357 | ret = PTR_ERR(msm_host->byte_clk); | 357 | ret = PTR_ERR(msm_host->byte_clk); |
358 | pr_err("%s: can't find dsi_byte_clk. ret=%d\n", | 358 | pr_err("%s: can't find dsi_byte clock. ret=%d\n", |
359 | __func__, ret); | 359 | __func__, ret); |
360 | msm_host->byte_clk = NULL; | 360 | msm_host->byte_clk = NULL; |
361 | goto exit; | 361 | goto exit; |
362 | } | 362 | } |
363 | 363 | ||
364 | msm_host->pixel_clk = devm_clk_get(dev, "pixel_clk"); | 364 | msm_host->pixel_clk = msm_clk_get(pdev, "pixel"); |
365 | if (IS_ERR(msm_host->pixel_clk)) { | 365 | if (IS_ERR(msm_host->pixel_clk)) { |
366 | ret = PTR_ERR(msm_host->pixel_clk); | 366 | ret = PTR_ERR(msm_host->pixel_clk); |
367 | pr_err("%s: can't find dsi_pixel_clk. ret=%d\n", | 367 | pr_err("%s: can't find dsi_pixel clock. ret=%d\n", |
368 | __func__, ret); | 368 | __func__, ret); |
369 | msm_host->pixel_clk = NULL; | 369 | msm_host->pixel_clk = NULL; |
370 | goto exit; | 370 | goto exit; |
371 | } | 371 | } |
372 | 372 | ||
373 | msm_host->esc_clk = devm_clk_get(dev, "core_clk"); | 373 | msm_host->esc_clk = msm_clk_get(pdev, "core"); |
374 | if (IS_ERR(msm_host->esc_clk)) { | 374 | if (IS_ERR(msm_host->esc_clk)) { |
375 | ret = PTR_ERR(msm_host->esc_clk); | 375 | ret = PTR_ERR(msm_host->esc_clk); |
376 | pr_err("%s: can't find dsi_esc_clk. ret=%d\n", | 376 | pr_err("%s: can't find dsi_esc clock. ret=%d\n", |
377 | __func__, ret); | 377 | __func__, ret); |
378 | msm_host->esc_clk = NULL; | 378 | msm_host->esc_clk = NULL; |
379 | goto exit; | 379 | goto exit; |
@@ -382,22 +382,22 @@ static int dsi_clk_init(struct msm_dsi_host *msm_host) | |||
382 | msm_host->byte_clk_src = clk_get_parent(msm_host->byte_clk); | 382 | msm_host->byte_clk_src = clk_get_parent(msm_host->byte_clk); |
383 | if (!msm_host->byte_clk_src) { | 383 | if (!msm_host->byte_clk_src) { |
384 | ret = -ENODEV; | 384 | ret = -ENODEV; |
385 | pr_err("%s: can't find byte_clk_src. ret=%d\n", __func__, ret); | 385 | pr_err("%s: can't find byte_clk clock. ret=%d\n", __func__, ret); |
386 | goto exit; | 386 | goto exit; |
387 | } | 387 | } |
388 | 388 | ||
389 | msm_host->pixel_clk_src = clk_get_parent(msm_host->pixel_clk); | 389 | msm_host->pixel_clk_src = clk_get_parent(msm_host->pixel_clk); |
390 | if (!msm_host->pixel_clk_src) { | 390 | if (!msm_host->pixel_clk_src) { |
391 | ret = -ENODEV; | 391 | ret = -ENODEV; |
392 | pr_err("%s: can't find pixel_clk_src. ret=%d\n", __func__, ret); | 392 | pr_err("%s: can't find pixel_clk clock. ret=%d\n", __func__, ret); |
393 | goto exit; | 393 | goto exit; |
394 | } | 394 | } |
395 | 395 | ||
396 | if (cfg_hnd->major == MSM_DSI_VER_MAJOR_V2) { | 396 | if (cfg_hnd->major == MSM_DSI_VER_MAJOR_V2) { |
397 | msm_host->src_clk = devm_clk_get(dev, "src_clk"); | 397 | msm_host->src_clk = msm_clk_get(pdev, "src"); |
398 | if (IS_ERR(msm_host->src_clk)) { | 398 | if (IS_ERR(msm_host->src_clk)) { |
399 | ret = PTR_ERR(msm_host->src_clk); | 399 | ret = PTR_ERR(msm_host->src_clk); |
400 | pr_err("%s: can't find dsi_src_clk. ret=%d\n", | 400 | pr_err("%s: can't find src clock. ret=%d\n", |
401 | __func__, ret); | 401 | __func__, ret); |
402 | msm_host->src_clk = NULL; | 402 | msm_host->src_clk = NULL; |
403 | goto exit; | 403 | goto exit; |
@@ -406,7 +406,7 @@ static int dsi_clk_init(struct msm_dsi_host *msm_host) | |||
406 | msm_host->esc_clk_src = clk_get_parent(msm_host->esc_clk); | 406 | msm_host->esc_clk_src = clk_get_parent(msm_host->esc_clk); |
407 | if (!msm_host->esc_clk_src) { | 407 | if (!msm_host->esc_clk_src) { |
408 | ret = -ENODEV; | 408 | ret = -ENODEV; |
409 | pr_err("%s: can't get esc_clk_src. ret=%d\n", | 409 | pr_err("%s: can't get esc clock parent. ret=%d\n", |
410 | __func__, ret); | 410 | __func__, ret); |
411 | goto exit; | 411 | goto exit; |
412 | } | 412 | } |
@@ -414,7 +414,7 @@ static int dsi_clk_init(struct msm_dsi_host *msm_host) | |||
414 | msm_host->dsi_clk_src = clk_get_parent(msm_host->src_clk); | 414 | msm_host->dsi_clk_src = clk_get_parent(msm_host->src_clk); |
415 | if (!msm_host->dsi_clk_src) { | 415 | if (!msm_host->dsi_clk_src) { |
416 | ret = -ENODEV; | 416 | ret = -ENODEV; |
417 | pr_err("%s: can't get dsi_clk_src. ret=%d\n", | 417 | pr_err("%s: can't get src clock parent. ret=%d\n", |
418 | __func__, ret); | 418 | __func__, ret); |
419 | } | 419 | } |
420 | } | 420 | } |
diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c index 7c9bf91bc22b..790ca280cbfd 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | |||
@@ -482,7 +482,7 @@ static int dsi_phy_driver_probe(struct platform_device *pdev) | |||
482 | goto fail; | 482 | goto fail; |
483 | } | 483 | } |
484 | 484 | ||
485 | phy->ahb_clk = devm_clk_get(dev, "iface_clk"); | 485 | phy->ahb_clk = msm_clk_get(pdev, "iface"); |
486 | if (IS_ERR(phy->ahb_clk)) { | 486 | if (IS_ERR(phy->ahb_clk)) { |
487 | dev_err(dev, "%s: Unable to get ahb clk\n", __func__); | 487 | dev_err(dev, "%s: Unable to get ahb clk\n", __func__); |
488 | ret = PTR_ERR(phy->ahb_clk); | 488 | ret = PTR_ERR(phy->ahb_clk); |