diff options
author | David Gibson <david@gibson.dropbear.id.au> | 2016-12-20 00:48:59 -0500 |
---|---|---|
committer | Paul Mackerras <paulus@ozlabs.org> | 2017-01-31 05:59:23 -0500 |
commit | db9a290d9c3c596e5325e2a42133594435e5de46 (patch) | |
tree | 73828560dd1cfca21d325f77721108a0f67ded96 | |
parent | ef1ead0c3b1dfb43d33caa4f50c8d214f86b6bc8 (diff) |
KVM: PPC: Book3S HV: Rename kvm_alloc_hpt() for clarity
The difference between kvm_alloc_hpt() and kvmppc_alloc_hpt() is not at
all obvious from the name. In practice kvmppc_alloc_hpt() allocates an HPT
by whatever means, and calls kvm_alloc_hpt() which will attempt to allocate
it with CMA only.
To make this less confusing, rename kvm_alloc_hpt() to kvm_alloc_hpt_cma().
Similarly, kvm_release_hpt() is renamed kvm_free_hpt_cma().
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
-rw-r--r-- | arch/powerpc/include/asm/kvm_ppc.h | 4 | ||||
-rw-r--r-- | arch/powerpc/kvm/book3s_64_mmu_hv.c | 8 | ||||
-rw-r--r-- | arch/powerpc/kvm/book3s_hv_builtin.c | 8 |
3 files changed, 10 insertions, 10 deletions
diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h index 48c760f89590..6fad1f12e9ec 100644 --- a/arch/powerpc/include/asm/kvm_ppc.h +++ b/arch/powerpc/include/asm/kvm_ppc.h | |||
@@ -186,8 +186,8 @@ extern long kvmppc_h_stuff_tce(struct kvm_vcpu *vcpu, | |||
186 | unsigned long tce_value, unsigned long npages); | 186 | unsigned long tce_value, unsigned long npages); |
187 | extern long kvmppc_h_get_tce(struct kvm_vcpu *vcpu, unsigned long liobn, | 187 | extern long kvmppc_h_get_tce(struct kvm_vcpu *vcpu, unsigned long liobn, |
188 | unsigned long ioba); | 188 | unsigned long ioba); |
189 | extern struct page *kvm_alloc_hpt(unsigned long nr_pages); | 189 | extern struct page *kvm_alloc_hpt_cma(unsigned long nr_pages); |
190 | extern void kvm_release_hpt(struct page *page, unsigned long nr_pages); | 190 | extern void kvm_free_hpt_cma(struct page *page, unsigned long nr_pages); |
191 | extern int kvmppc_core_init_vm(struct kvm *kvm); | 191 | extern int kvmppc_core_init_vm(struct kvm *kvm); |
192 | extern void kvmppc_core_destroy_vm(struct kvm *kvm); | 192 | extern void kvmppc_core_destroy_vm(struct kvm *kvm); |
193 | extern void kvmppc_core_free_memslot(struct kvm *kvm, | 193 | extern void kvmppc_core_free_memslot(struct kvm *kvm, |
diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c index 9df3d940acec..16f278417c69 100644 --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c | |||
@@ -62,7 +62,7 @@ long kvmppc_alloc_hpt(struct kvm *kvm, u32 *htab_orderp) | |||
62 | } | 62 | } |
63 | 63 | ||
64 | kvm->arch.hpt_cma_alloc = 0; | 64 | kvm->arch.hpt_cma_alloc = 0; |
65 | page = kvm_alloc_hpt(1ul << (order - PAGE_SHIFT)); | 65 | page = kvm_alloc_hpt_cma(1ul << (order - PAGE_SHIFT)); |
66 | if (page) { | 66 | if (page) { |
67 | hpt = (unsigned long)pfn_to_kaddr(page_to_pfn(page)); | 67 | hpt = (unsigned long)pfn_to_kaddr(page_to_pfn(page)); |
68 | memset((void *)hpt, 0, (1ul << order)); | 68 | memset((void *)hpt, 0, (1ul << order)); |
@@ -108,7 +108,7 @@ long kvmppc_alloc_hpt(struct kvm *kvm, u32 *htab_orderp) | |||
108 | 108 | ||
109 | out_freehpt: | 109 | out_freehpt: |
110 | if (kvm->arch.hpt_cma_alloc) | 110 | if (kvm->arch.hpt_cma_alloc) |
111 | kvm_release_hpt(page, 1 << (order - PAGE_SHIFT)); | 111 | kvm_free_hpt_cma(page, 1 << (order - PAGE_SHIFT)); |
112 | else | 112 | else |
113 | free_pages(hpt, order - PAGE_SHIFT); | 113 | free_pages(hpt, order - PAGE_SHIFT); |
114 | return -ENOMEM; | 114 | return -ENOMEM; |
@@ -157,8 +157,8 @@ void kvmppc_free_hpt(struct kvm *kvm) | |||
157 | { | 157 | { |
158 | vfree(kvm->arch.revmap); | 158 | vfree(kvm->arch.revmap); |
159 | if (kvm->arch.hpt_cma_alloc) | 159 | if (kvm->arch.hpt_cma_alloc) |
160 | kvm_release_hpt(virt_to_page(kvm->arch.hpt_virt), | 160 | kvm_free_hpt_cma(virt_to_page(kvm->arch.hpt_virt), |
161 | 1 << (kvm->arch.hpt_order - PAGE_SHIFT)); | 161 | 1 << (kvm->arch.hpt_order - PAGE_SHIFT)); |
162 | else if (kvm->arch.hpt_virt) | 162 | else if (kvm->arch.hpt_virt) |
163 | free_pages(kvm->arch.hpt_virt, | 163 | free_pages(kvm->arch.hpt_virt, |
164 | kvm->arch.hpt_order - PAGE_SHIFT); | 164 | kvm->arch.hpt_order - PAGE_SHIFT); |
diff --git a/arch/powerpc/kvm/book3s_hv_builtin.c b/arch/powerpc/kvm/book3s_hv_builtin.c index fe08fea54b70..96e7e609f621 100644 --- a/arch/powerpc/kvm/book3s_hv_builtin.c +++ b/arch/powerpc/kvm/book3s_hv_builtin.c | |||
@@ -57,19 +57,19 @@ static int __init early_parse_kvm_cma_resv(char *p) | |||
57 | } | 57 | } |
58 | early_param("kvm_cma_resv_ratio", early_parse_kvm_cma_resv); | 58 | early_param("kvm_cma_resv_ratio", early_parse_kvm_cma_resv); |
59 | 59 | ||
60 | struct page *kvm_alloc_hpt(unsigned long nr_pages) | 60 | struct page *kvm_alloc_hpt_cma(unsigned long nr_pages) |
61 | { | 61 | { |
62 | VM_BUG_ON(order_base_2(nr_pages) < KVM_CMA_CHUNK_ORDER - PAGE_SHIFT); | 62 | VM_BUG_ON(order_base_2(nr_pages) < KVM_CMA_CHUNK_ORDER - PAGE_SHIFT); |
63 | 63 | ||
64 | return cma_alloc(kvm_cma, nr_pages, order_base_2(HPT_ALIGN_PAGES)); | 64 | return cma_alloc(kvm_cma, nr_pages, order_base_2(HPT_ALIGN_PAGES)); |
65 | } | 65 | } |
66 | EXPORT_SYMBOL_GPL(kvm_alloc_hpt); | 66 | EXPORT_SYMBOL_GPL(kvm_alloc_hpt_cma); |
67 | 67 | ||
68 | void kvm_release_hpt(struct page *page, unsigned long nr_pages) | 68 | void kvm_free_hpt_cma(struct page *page, unsigned long nr_pages) |
69 | { | 69 | { |
70 | cma_release(kvm_cma, page, nr_pages); | 70 | cma_release(kvm_cma, page, nr_pages); |
71 | } | 71 | } |
72 | EXPORT_SYMBOL_GPL(kvm_release_hpt); | 72 | EXPORT_SYMBOL_GPL(kvm_free_hpt_cma); |
73 | 73 | ||
74 | /** | 74 | /** |
75 | * kvm_cma_reserve() - reserve area for kvm hash pagetable | 75 | * kvm_cma_reserve() - reserve area for kvm hash pagetable |