diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2018-04-03 15:14:54 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-04-03 15:14:54 -0400 |
commit | dabe51840e2790aa7e66c53990d15c663b0d628a (patch) | |
tree | 064f250b09f56feecd567e8c4c9a575b8790900c | |
parent | 3ac684b88148bf132fbf02a133cba9dcfb2e7aa2 (diff) | |
parent | e3d7fbab062b877b96c09ffb43733502cdc1bd0a (diff) |
Merge tag 'hsi-for-4.17' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi
Pull HSI updates from Sebastian Reichel:
- spelling/typo fixes
- remove extra error printing for -ENOMEM
* tag 'hsi-for-4.17' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi:
HSI: hsi_char: Delete an error message for a failed memory allocation in hsc_probe()
HSI: ssi_protocol: fix spelling mistake: "trigerred" -> "triggered"
HSI: ssi_protocol: Delete an error message for a failed memory allocation in ssi_protocol_probe()
HSI: ssi_protocol: Fix a typo in two comment lines
-rw-r--r-- | drivers/hsi/clients/hsi_char.c | 5 | ||||
-rw-r--r-- | drivers/hsi/clients/ssi_protocol.c | 12 |
2 files changed, 7 insertions, 10 deletions
diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c index cf9c2a332ad8..9d2a6d64dfb8 100644 --- a/drivers/hsi/clients/hsi_char.c +++ b/drivers/hsi/clients/hsi_char.c | |||
@@ -697,10 +697,9 @@ static int hsc_probe(struct device *dev) | |||
697 | int i; | 697 | int i; |
698 | 698 | ||
699 | cl_data = kzalloc(sizeof(*cl_data), GFP_KERNEL); | 699 | cl_data = kzalloc(sizeof(*cl_data), GFP_KERNEL); |
700 | if (!cl_data) { | 700 | if (!cl_data) |
701 | dev_err(dev, "Could not allocate hsc_client_data\n"); | ||
702 | return -ENOMEM; | 701 | return -ENOMEM; |
703 | } | 702 | |
704 | hsc_baseminor = HSC_BASEMINOR(hsi_id(cl), hsi_port_id(cl)); | 703 | hsc_baseminor = HSC_BASEMINOR(hsi_id(cl), hsi_port_id(cl)); |
705 | if (!hsc_major) { | 704 | if (!hsc_major) { |
706 | ret = alloc_chrdev_region(&hsc_dev, hsc_baseminor, | 705 | ret = alloc_chrdev_region(&hsc_dev, hsc_baseminor, |
diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c index 9b167bc6eee4..561abf7bdf1f 100644 --- a/drivers/hsi/clients/ssi_protocol.c +++ b/drivers/hsi/clients/ssi_protocol.c | |||
@@ -495,7 +495,7 @@ static void ssip_rx_wd(struct timer_list *t) | |||
495 | struct ssi_protocol *ssi = from_timer(ssi, t, rx_wd); | 495 | struct ssi_protocol *ssi = from_timer(ssi, t, rx_wd); |
496 | struct hsi_client *cl = ssi->cl; | 496 | struct hsi_client *cl = ssi->cl; |
497 | 497 | ||
498 | dev_err(&cl->device, "Watchdog trigerred\n"); | 498 | dev_err(&cl->device, "Watchdog triggered\n"); |
499 | ssip_error(cl); | 499 | ssip_error(cl); |
500 | } | 500 | } |
501 | 501 | ||
@@ -504,7 +504,7 @@ static void ssip_tx_wd(struct timer_list *t) | |||
504 | struct ssi_protocol *ssi = from_timer(ssi, t, tx_wd); | 504 | struct ssi_protocol *ssi = from_timer(ssi, t, tx_wd); |
505 | struct hsi_client *cl = ssi->cl; | 505 | struct hsi_client *cl = ssi->cl; |
506 | 506 | ||
507 | dev_err(&cl->device, "Watchdog trigerred\n"); | 507 | dev_err(&cl->device, "Watchdog triggered\n"); |
508 | ssip_error(cl); | 508 | ssip_error(cl); |
509 | } | 509 | } |
510 | 510 | ||
@@ -993,8 +993,8 @@ static int ssip_pn_xmit(struct sk_buff *skb, struct net_device *dev) | |||
993 | goto inc_dropped; | 993 | goto inc_dropped; |
994 | 994 | ||
995 | /* | 995 | /* |
996 | * Modem sends Phonet messages over SSI with its own endianess... | 996 | * Modem sends Phonet messages over SSI with its own endianness. |
997 | * Assume that modem has the same endianess as we do. | 997 | * Assume that modem has the same endianness as we do. |
998 | */ | 998 | */ |
999 | if (skb_cow_head(skb, 0)) | 999 | if (skb_cow_head(skb, 0)) |
1000 | goto drop; | 1000 | goto drop; |
@@ -1088,10 +1088,8 @@ static int ssi_protocol_probe(struct device *dev) | |||
1088 | int err; | 1088 | int err; |
1089 | 1089 | ||
1090 | ssi = kzalloc(sizeof(*ssi), GFP_KERNEL); | 1090 | ssi = kzalloc(sizeof(*ssi), GFP_KERNEL); |
1091 | if (!ssi) { | 1091 | if (!ssi) |
1092 | dev_err(dev, "No memory for ssi protocol\n"); | ||
1093 | return -ENOMEM; | 1092 | return -ENOMEM; |
1094 | } | ||
1095 | 1093 | ||
1096 | spin_lock_init(&ssi->lock); | 1094 | spin_lock_init(&ssi->lock); |
1097 | timer_setup(&ssi->rx_wd, ssip_rx_wd, TIMER_DEFERRABLE); | 1095 | timer_setup(&ssi->rx_wd, ssip_rx_wd, TIMER_DEFERRABLE); |