diff options
author | Josh Poimboeuf <jpoimboe@redhat.com> | 2016-08-19 07:52:56 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2016-08-24 06:15:14 -0400 |
commit | daa460a88c09b26b68e8b017de589c217e901afb (patch) | |
tree | d57e0a053fac1bc06cfd29194bc578bc5b68d88c | |
parent | e4a744ef2fef5c803348b650a3a2d01da7797a9b (diff) |
ftrace: Only allocate the ret_stack 'fp' field when needed
This saves some memory when HAVE_FUNCTION_GRAPH_FP_TEST isn't defined.
On x86_64 with newer versions of gcc which have -mfentry, it saves 400
bytes per task.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Byungchul Park <byungchul.park@lge.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nilay Vaish <nilayvaish@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/5c7747d9ea7b5cb47ef0a8ce8a6cea6bf7aa94bf.1471607358.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | include/linux/ftrace.h | 2 | ||||
-rw-r--r-- | kernel/trace/trace_functions_graph.c | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h index 7d565afe35d2..4ad9ccc60e38 100644 --- a/include/linux/ftrace.h +++ b/include/linux/ftrace.h | |||
@@ -795,7 +795,9 @@ struct ftrace_ret_stack { | |||
795 | unsigned long func; | 795 | unsigned long func; |
796 | unsigned long long calltime; | 796 | unsigned long long calltime; |
797 | unsigned long long subtime; | 797 | unsigned long long subtime; |
798 | #ifdef HAVE_FUNCTION_GRAPH_FP_TEST | ||
798 | unsigned long fp; | 799 | unsigned long fp; |
800 | #endif | ||
799 | }; | 801 | }; |
800 | 802 | ||
801 | /* | 803 | /* |
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c index fc173cd9fbfd..0e03ed0eac68 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c | |||
@@ -171,7 +171,9 @@ ftrace_push_return_trace(unsigned long ret, unsigned long func, int *depth, | |||
171 | current->ret_stack[index].func = func; | 171 | current->ret_stack[index].func = func; |
172 | current->ret_stack[index].calltime = calltime; | 172 | current->ret_stack[index].calltime = calltime; |
173 | current->ret_stack[index].subtime = 0; | 173 | current->ret_stack[index].subtime = 0; |
174 | #ifdef HAVE_FUNCTION_GRAPH_FP_TEST | ||
174 | current->ret_stack[index].fp = frame_pointer; | 175 | current->ret_stack[index].fp = frame_pointer; |
176 | #endif | ||
175 | *depth = current->curr_ret_stack; | 177 | *depth = current->curr_ret_stack; |
176 | 178 | ||
177 | return 0; | 179 | return 0; |