aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVineet Gupta <vgupta@synopsys.com>2016-02-18 21:48:11 -0500
committerVineet Gupta <vgupta@synopsys.com>2016-02-24 00:37:32 -0500
commitd73b73f5626ac0b131b31b7b9457e19201bc570b (patch)
treea18e34e5a030277ad20ba88186cd3e4211a3d5c6
parent3dea30ca5bef0e013abe857057a952a9d6757fe5 (diff)
ARC: SMP: No need for CONFIG_ARC_IPI_DBG
This was more relevant during SMP bringup. The warning for bogus msg better be visible always. Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
-rw-r--r--arch/arc/Kconfig8
-rw-r--r--arch/arc/kernel/mcip.c9
-rw-r--r--arch/arc/kernel/smp.c3
3 files changed, 1 insertions, 19 deletions
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
index 4abc81907071..8a188bc1786a 100644
--- a/arch/arc/Kconfig
+++ b/arch/arc/Kconfig
@@ -532,14 +532,6 @@ config ARC_DBG_TLB_MISS_COUNT
532 Counts number of I and D TLB Misses and exports them via Debugfs 532 Counts number of I and D TLB Misses and exports them via Debugfs
533 The counters can be cleared via Debugfs as well 533 The counters can be cleared via Debugfs as well
534 534
535if SMP
536
537config ARC_IPI_DBG
538 bool "Debug Inter Core interrupts"
539 default n
540
541endif
542
543endif 535endif
544 536
545config ARC_UBOOT_SUPPORT 537config ARC_UBOOT_SUPPORT
diff --git a/arch/arc/kernel/mcip.c b/arch/arc/kernel/mcip.c
index 7afc3c703ed1..7b4af70ffd18 100644
--- a/arch/arc/kernel/mcip.c
+++ b/arch/arc/kernel/mcip.c
@@ -65,7 +65,6 @@ static void mcip_ipi_clear(int irq)
65{ 65{
66 unsigned int cpu, c; 66 unsigned int cpu, c;
67 unsigned long flags; 67 unsigned long flags;
68 unsigned int __maybe_unused copy;
69 68
70 if (unlikely(irq == SOFTIRQ_IRQ)) { 69 if (unlikely(irq == SOFTIRQ_IRQ)) {
71 arc_softirq_clear(irq); 70 arc_softirq_clear(irq);
@@ -77,7 +76,7 @@ static void mcip_ipi_clear(int irq)
77 /* Who sent the IPI */ 76 /* Who sent the IPI */
78 __mcip_cmd(CMD_INTRPT_CHECK_SOURCE, 0); 77 __mcip_cmd(CMD_INTRPT_CHECK_SOURCE, 0);
79 78
80 copy = cpu = read_aux_reg(ARC_REG_MCIP_READBACK); /* 1,2,4,8... */ 79 cpu = read_aux_reg(ARC_REG_MCIP_READBACK); /* 1,2,4,8... */
81 80
82 /* 81 /*
83 * In rare case, multiple concurrent IPIs sent to same target can 82 * In rare case, multiple concurrent IPIs sent to same target can
@@ -91,12 +90,6 @@ static void mcip_ipi_clear(int irq)
91 } while (cpu); 90 } while (cpu);
92 91
93 raw_spin_unlock_irqrestore(&mcip_lock, flags); 92 raw_spin_unlock_irqrestore(&mcip_lock, flags);
94
95#ifdef CONFIG_ARC_IPI_DBG
96 if (c != __ffs(copy))
97 pr_info("IPIs from %x coalesced to %x\n",
98 copy, raw_smp_processor_id());
99#endif
100} 93}
101 94
102static void mcip_probe_n_setup(void) 95static void mcip_probe_n_setup(void)
diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c
index ef6e9e15b82a..424e937da5c8 100644
--- a/arch/arc/kernel/smp.c
+++ b/arch/arc/kernel/smp.c
@@ -336,11 +336,8 @@ irqreturn_t do_IPI(int irq, void *dev_id)
336 int rc; 336 int rc;
337 337
338 rc = __do_IPI(msg); 338 rc = __do_IPI(msg);
339#ifdef CONFIG_ARC_IPI_DBG
340 /* IPI received but no valid @msg */
341 if (rc) 339 if (rc)
342 pr_info("IPI with bogus msg %ld in %ld\n", msg, copy); 340 pr_info("IPI with bogus msg %ld in %ld\n", msg, copy);
343#endif
344 pending &= ~(1U << msg); 341 pending &= ~(1U << msg);
345 } while (pending); 342 } while (pending);
346 343