aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMasahiro Yamada <yamada.masahiro@socionext.com>2017-11-14 06:38:07 -0500
committerMasahiro Yamada <yamada.masahiro@socionext.com>2017-11-23 09:12:03 -0500
commitd7059ca0147adcd495f3c5b41f260e1ac55bb679 (patch)
treeaa1e5753e64ae9c5a11cd340915e3e3196c828cd
parent88127dae6ed9d6aa938e9cf1776dc90b897fc1f7 (diff)
coccinelle: fix parallel build with CHECK=scripts/coccicheck
The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of "coccicheck failed" error messages. Julia Lawall explained the Coccinelle behavior as follows: "The problem on the Coccinelle side is that it uses a subdirectory with the name of the semantic patch to store standard output and standard error for the different threads. I didn't want to use a name with the pid, so that one could easily find this information while Coccinelle is running. Normally the subdirectory is cleaned up when Coccinelle completes, so there is only one of them at a time. Maybe it is best to just add the pid. There is the risk that these subdirectories will accumulate if Coccinelle crashes in a way such that they don't get cleaned up, but Coccinelle could print a warning if it detects this case, rather than failing." When scripts/coccicheck is used as CHECK tool and -j option is given to Make, the whole of build process runs in parallel. So, multiple processes try to get access to the same subdirectory. I notice spatch creates the subdirectory only when it runs in parallel (i.e. --jobs <N> is given and <N> is greater than 1). Setting NPROC=1 is a reasonable solution; spatch does not create the subdirectory. Besides, ONLINE=1 mode takes a single file input for each spatch invocation, so there is no reason to parallelize it in the first place. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Julia Lawall <Julia.Lawall@lip6.fr>
-rwxr-xr-xscripts/coccicheck15
1 files changed, 9 insertions, 6 deletions
diff --git a/scripts/coccicheck b/scripts/coccicheck
index d5f28d5044e7..ecfac64b39fe 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -30,12 +30,6 @@ else
30 VERBOSE=0 30 VERBOSE=0
31fi 31fi
32 32
33if [ -z "$J" ]; then
34 NPROC=$(getconf _NPROCESSORS_ONLN)
35else
36 NPROC="$J"
37fi
38
39FLAGS="--very-quiet" 33FLAGS="--very-quiet"
40 34
41# You can use SPFLAGS to append extra arguments to coccicheck or override any 35# You can use SPFLAGS to append extra arguments to coccicheck or override any
@@ -70,6 +64,9 @@ if [ "$C" = "1" -o "$C" = "2" ]; then
70 # Take only the last argument, which is the C file to test 64 # Take only the last argument, which is the C file to test
71 shift $(( $# - 1 )) 65 shift $(( $# - 1 ))
72 OPTIONS="$COCCIINCLUDE $1" 66 OPTIONS="$COCCIINCLUDE $1"
67
68 # No need to parallelize Coccinelle since this mode takes one input file.
69 NPROC=1
73else 70else
74 ONLINE=0 71 ONLINE=0
75 if [ "$KBUILD_EXTMOD" = "" ] ; then 72 if [ "$KBUILD_EXTMOD" = "" ] ; then
@@ -77,6 +74,12 @@ else
77 else 74 else
78 OPTIONS="--dir $KBUILD_EXTMOD $COCCIINCLUDE" 75 OPTIONS="--dir $KBUILD_EXTMOD $COCCIINCLUDE"
79 fi 76 fi
77
78 if [ -z "$J" ]; then
79 NPROC=$(getconf _NPROCESSORS_ONLN)
80 else
81 NPROC="$J"
82 fi
80fi 83fi
81 84
82if [ "$KBUILD_EXTMOD" != "" ] ; then 85if [ "$KBUILD_EXTMOD" != "" ] ; then