diff options
author | Arvind Yadav <arvind.yadav.cs@gmail.com> | 2017-11-29 11:17:11 -0500 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2017-12-01 08:05:45 -0500 |
commit | d6e2c4ffdf67de68e0263630525d2b521132d66a (patch) | |
tree | 8585b049e7db840875cf8870bef3aa8167647bb2 | |
parent | 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323 (diff) |
ASoC: mt8173: Fix platform_get_irq's error checking
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c index 8a643a35d3d4..c7f7f8add5d9 100644 --- a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c +++ b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | |||
@@ -1083,7 +1083,7 @@ static int mt8173_afe_init_audio_clk(struct mtk_base_afe *afe) | |||
1083 | static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev) | 1083 | static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev) |
1084 | { | 1084 | { |
1085 | int ret, i; | 1085 | int ret, i; |
1086 | unsigned int irq_id; | 1086 | int irq_id; |
1087 | struct mtk_base_afe *afe; | 1087 | struct mtk_base_afe *afe; |
1088 | struct mt8173_afe_private *afe_priv; | 1088 | struct mt8173_afe_private *afe_priv; |
1089 | struct resource *res; | 1089 | struct resource *res; |
@@ -1105,9 +1105,9 @@ static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev) | |||
1105 | afe->dev = &pdev->dev; | 1105 | afe->dev = &pdev->dev; |
1106 | 1106 | ||
1107 | irq_id = platform_get_irq(pdev, 0); | 1107 | irq_id = platform_get_irq(pdev, 0); |
1108 | if (!irq_id) { | 1108 | if (irq_id <= 0) { |
1109 | dev_err(afe->dev, "np %s no irq\n", afe->dev->of_node->name); | 1109 | dev_err(afe->dev, "np %s no irq\n", afe->dev->of_node->name); |
1110 | return -ENXIO; | 1110 | return irq_id < 0 ? irq_id : -ENXIO; |
1111 | } | 1111 | } |
1112 | ret = devm_request_irq(afe->dev, irq_id, mt8173_afe_irq_handler, | 1112 | ret = devm_request_irq(afe->dev, irq_id, mt8173_afe_irq_handler, |
1113 | 0, "Afe_ISR_Handle", (void *)afe); | 1113 | 0, "Afe_ISR_Handle", (void *)afe); |