diff options
author | PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> | 2016-08-25 13:00:50 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-08-31 08:12:35 -0400 |
commit | d6a38c0ba778abd6683858bfd7c768f7edab2ebb (patch) | |
tree | c551509f81466432748179919b33775292e24abc | |
parent | ca75d601b5942e8cf5eed68f308be0526d0dac5d (diff) |
miscdevice: Use module_misc_device() macro
This patch removes module_init()/module_exit() from driver code by using
module_misc_device() macro. All modules in this patch has a print
statement which is removed when module_misc_device() macro is used.
If undesirable this patch can be dropped entirely, this is the only
purpose of making this as a separate patch.
Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | arch/um/drivers/harddog_kern.c | 25 | ||||
-rw-r--r-- | drivers/bluetooth/hci_vhci.c | 16 | ||||
-rw-r--r-- | drivers/char/bfin-otp.c | 40 | ||||
-rw-r--r-- | drivers/lightnvm/core.c | 19 |
4 files changed, 4 insertions, 96 deletions
diff --git a/arch/um/drivers/harddog_kern.c b/arch/um/drivers/harddog_kern.c index 2d0266d0254d..3282787bbcfb 100644 --- a/arch/um/drivers/harddog_kern.c +++ b/arch/um/drivers/harddog_kern.c | |||
@@ -175,27 +175,4 @@ static struct miscdevice harddog_miscdev = { | |||
175 | .name = "watchdog", | 175 | .name = "watchdog", |
176 | .fops = &harddog_fops, | 176 | .fops = &harddog_fops, |
177 | }; | 177 | }; |
178 | 178 | module_misc_device(harddog_miscdev); | |
179 | static char banner[] __initdata = KERN_INFO "UML Watchdog Timer\n"; | ||
180 | |||
181 | static int __init harddog_init(void) | ||
182 | { | ||
183 | int ret; | ||
184 | |||
185 | ret = misc_register(&harddog_miscdev); | ||
186 | |||
187 | if (ret) | ||
188 | return ret; | ||
189 | |||
190 | printk(banner); | ||
191 | |||
192 | return 0; | ||
193 | } | ||
194 | |||
195 | static void __exit harddog_exit(void) | ||
196 | { | ||
197 | misc_deregister(&harddog_miscdev); | ||
198 | } | ||
199 | |||
200 | module_init(harddog_init); | ||
201 | module_exit(harddog_exit); | ||
diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c index 3ff229b2e7f3..c4a75a18dcae 100644 --- a/drivers/bluetooth/hci_vhci.c +++ b/drivers/bluetooth/hci_vhci.c | |||
@@ -377,21 +377,7 @@ static struct miscdevice vhci_miscdev = { | |||
377 | .fops = &vhci_fops, | 377 | .fops = &vhci_fops, |
378 | .minor = VHCI_MINOR, | 378 | .minor = VHCI_MINOR, |
379 | }; | 379 | }; |
380 | 380 | module_misc_device(vhci_miscdev); | |
381 | static int __init vhci_init(void) | ||
382 | { | ||
383 | BT_INFO("Virtual HCI driver ver %s", VERSION); | ||
384 | |||
385 | return misc_register(&vhci_miscdev); | ||
386 | } | ||
387 | |||
388 | static void __exit vhci_exit(void) | ||
389 | { | ||
390 | misc_deregister(&vhci_miscdev); | ||
391 | } | ||
392 | |||
393 | module_init(vhci_init); | ||
394 | module_exit(vhci_exit); | ||
395 | 381 | ||
396 | module_param(amp, bool, 0644); | 382 | module_param(amp, bool, 0644); |
397 | MODULE_PARM_DESC(amp, "Create AMP controller device"); | 383 | MODULE_PARM_DESC(amp, "Create AMP controller device"); |
diff --git a/drivers/char/bfin-otp.c b/drivers/char/bfin-otp.c index 44660f1c4849..35d46da754d7 100644 --- a/drivers/char/bfin-otp.c +++ b/drivers/char/bfin-otp.c | |||
@@ -230,45 +230,7 @@ static struct miscdevice bfin_otp_misc_device = { | |||
230 | .name = DRIVER_NAME, | 230 | .name = DRIVER_NAME, |
231 | .fops = &bfin_otp_fops, | 231 | .fops = &bfin_otp_fops, |
232 | }; | 232 | }; |
233 | 233 | module_misc_device(bfin_otp_misc_device); | |
234 | /** | ||
235 | * bfin_otp_init - Initialize module | ||
236 | * | ||
237 | * Registers the device and notifier handler. Actual device | ||
238 | * initialization is handled by bfin_otp_open(). | ||
239 | */ | ||
240 | static int __init bfin_otp_init(void) | ||
241 | { | ||
242 | int ret; | ||
243 | |||
244 | stampit(); | ||
245 | |||
246 | ret = misc_register(&bfin_otp_misc_device); | ||
247 | if (ret) { | ||
248 | pr_init(KERN_ERR PFX "unable to register a misc device\n"); | ||
249 | return ret; | ||
250 | } | ||
251 | |||
252 | pr_init(KERN_INFO PFX "initialized\n"); | ||
253 | |||
254 | return 0; | ||
255 | } | ||
256 | |||
257 | /** | ||
258 | * bfin_otp_exit - Deinitialize module | ||
259 | * | ||
260 | * Unregisters the device and notifier handler. Actual device | ||
261 | * deinitialization is handled by bfin_otp_close(). | ||
262 | */ | ||
263 | static void __exit bfin_otp_exit(void) | ||
264 | { | ||
265 | stampit(); | ||
266 | |||
267 | misc_deregister(&bfin_otp_misc_device); | ||
268 | } | ||
269 | |||
270 | module_init(bfin_otp_init); | ||
271 | module_exit(bfin_otp_exit); | ||
272 | 234 | ||
273 | MODULE_AUTHOR("Mike Frysinger <vapier@gentoo.org>"); | 235 | MODULE_AUTHOR("Mike Frysinger <vapier@gentoo.org>"); |
274 | MODULE_DESCRIPTION("Blackfin OTP Memory Interface"); | 236 | MODULE_DESCRIPTION("Blackfin OTP Memory Interface"); |
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index 9ebd2cfbd849..c784ddcd4405 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c | |||
@@ -1171,27 +1171,10 @@ static struct miscdevice _nvm_misc = { | |||
1171 | .nodename = "lightnvm/control", | 1171 | .nodename = "lightnvm/control", |
1172 | .fops = &_ctl_fops, | 1172 | .fops = &_ctl_fops, |
1173 | }; | 1173 | }; |
1174 | module_misc_device(_nvm_misc); | ||
1174 | 1175 | ||
1175 | MODULE_ALIAS_MISCDEV(MISC_DYNAMIC_MINOR); | 1176 | MODULE_ALIAS_MISCDEV(MISC_DYNAMIC_MINOR); |
1176 | 1177 | ||
1177 | static int __init nvm_mod_init(void) | ||
1178 | { | ||
1179 | int ret; | ||
1180 | |||
1181 | ret = misc_register(&_nvm_misc); | ||
1182 | if (ret) | ||
1183 | pr_err("nvm: misc_register failed for control device"); | ||
1184 | |||
1185 | return ret; | ||
1186 | } | ||
1187 | |||
1188 | static void __exit nvm_mod_exit(void) | ||
1189 | { | ||
1190 | misc_deregister(&_nvm_misc); | ||
1191 | } | ||
1192 | |||
1193 | MODULE_AUTHOR("Matias Bjorling <m@bjorling.me>"); | 1178 | MODULE_AUTHOR("Matias Bjorling <m@bjorling.me>"); |
1194 | MODULE_LICENSE("GPL v2"); | 1179 | MODULE_LICENSE("GPL v2"); |
1195 | MODULE_VERSION("0.1"); | 1180 | MODULE_VERSION("0.1"); |
1196 | module_init(nvm_mod_init); | ||
1197 | module_exit(nvm_mod_exit); | ||