diff options
author | Meghana Madhyastha <meghana.madhyastha@gmail.com> | 2018-01-24 11:39:27 -0500 |
---|---|---|
committer | Sean Paul <seanpaul@chromium.org> | 2018-02-20 11:07:22 -0500 |
commit | d593bfdb62951313132b626b0fa5b3889335a108 (patch) | |
tree | 77a8a2baf73d55de8e582043bb05dc5f60404f42 | |
parent | 27f6640c8fa0adf5ea686189126dc2cd4642f21d (diff) |
drm/panel: Use backlight_enable/disable helpers
Use backlight_enable/disable helpers instead of changing
the property and calling backlight_update_status for cleaner
and simpler code and also to avoid repetitions.
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/bc80cdb5cf1a6638dce9fb9f8da674e361e3b749.1516810725.git.meghana.madhyastha@gmail.com
-rw-r--r-- | drivers/gpu/drm/panel/panel-innolux-p079zca.c | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 10 | ||||
-rw-r--r-- | drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 10 |
4 files changed, 8 insertions, 24 deletions
diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c index 6ba93449fcfb..4c1b29eec2a5 100644 --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c | |||
@@ -45,8 +45,7 @@ static int innolux_panel_disable(struct drm_panel *panel) | |||
45 | if (!innolux->enabled) | 45 | if (!innolux->enabled) |
46 | return 0; | 46 | return 0; |
47 | 47 | ||
48 | innolux->backlight->props.power = FB_BLANK_POWERDOWN; | 48 | backlight_disable(innolux->backlight); |
49 | backlight_update_status(innolux->backlight); | ||
50 | 49 | ||
51 | err = mipi_dsi_dcs_set_display_off(innolux->link); | 50 | err = mipi_dsi_dcs_set_display_off(innolux->link); |
52 | if (err < 0) | 51 | if (err < 0) |
@@ -151,8 +150,7 @@ static int innolux_panel_enable(struct drm_panel *panel) | |||
151 | if (innolux->enabled) | 150 | if (innolux->enabled) |
152 | return 0; | 151 | return 0; |
153 | 152 | ||
154 | innolux->backlight->props.power = FB_BLANK_UNBLANK; | 153 | ret = backlight_enable(innolux->backlight); |
155 | ret = backlight_update_status(innolux->backlight); | ||
156 | if (ret) { | 154 | if (ret) { |
157 | DRM_DEV_ERROR(panel->drm->dev, | 155 | DRM_DEV_ERROR(panel->drm->dev, |
158 | "Failed to enable backlight %d\n", ret); | 156 | "Failed to enable backlight %d\n", ret); |
diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c index 5b2340ef74ed..0a94ab79a6c0 100644 --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | |||
@@ -192,8 +192,7 @@ static int jdi_panel_disable(struct drm_panel *panel) | |||
192 | if (!jdi->enabled) | 192 | if (!jdi->enabled) |
193 | return 0; | 193 | return 0; |
194 | 194 | ||
195 | jdi->backlight->props.power = FB_BLANK_POWERDOWN; | 195 | backlight_disable(jdi->backlight); |
196 | backlight_update_status(jdi->backlight); | ||
197 | 196 | ||
198 | jdi->enabled = false; | 197 | jdi->enabled = false; |
199 | 198 | ||
@@ -289,8 +288,7 @@ static int jdi_panel_enable(struct drm_panel *panel) | |||
289 | if (jdi->enabled) | 288 | if (jdi->enabled) |
290 | return 0; | 289 | return 0; |
291 | 290 | ||
292 | jdi->backlight->props.power = FB_BLANK_UNBLANK; | 291 | backlight_enable(jdi->backlight); |
293 | backlight_update_status(jdi->backlight); | ||
294 | 292 | ||
295 | jdi->enabled = true; | 293 | jdi->enabled = true; |
296 | 294 | ||
diff --git a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c index 3cce3ca19601..072c0fc794d6 100644 --- a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c +++ b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | |||
@@ -96,10 +96,7 @@ static int sharp_panel_disable(struct drm_panel *panel) | |||
96 | if (!sharp->enabled) | 96 | if (!sharp->enabled) |
97 | return 0; | 97 | return 0; |
98 | 98 | ||
99 | if (sharp->backlight) { | 99 | backlight_disable(sharp->backlight); |
100 | sharp->backlight->props.power = FB_BLANK_POWERDOWN; | ||
101 | backlight_update_status(sharp->backlight); | ||
102 | } | ||
103 | 100 | ||
104 | sharp->enabled = false; | 101 | sharp->enabled = false; |
105 | 102 | ||
@@ -263,10 +260,7 @@ static int sharp_panel_enable(struct drm_panel *panel) | |||
263 | if (sharp->enabled) | 260 | if (sharp->enabled) |
264 | return 0; | 261 | return 0; |
265 | 262 | ||
266 | if (sharp->backlight) { | 263 | backlight_enable(sharp->backlight); |
267 | sharp->backlight->props.power = FB_BLANK_UNBLANK; | ||
268 | backlight_update_status(sharp->backlight); | ||
269 | } | ||
270 | 264 | ||
271 | sharp->enabled = true; | 265 | sharp->enabled = true; |
272 | 266 | ||
diff --git a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c index 3aeb0bda4947..8a5137963c7d 100644 --- a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c +++ b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | |||
@@ -117,10 +117,7 @@ static int sharp_nt_panel_disable(struct drm_panel *panel) | |||
117 | if (!sharp_nt->enabled) | 117 | if (!sharp_nt->enabled) |
118 | return 0; | 118 | return 0; |
119 | 119 | ||
120 | if (sharp_nt->backlight) { | 120 | backlight_disable(sharp_nt->backlight); |
121 | sharp_nt->backlight->props.power = FB_BLANK_POWERDOWN; | ||
122 | backlight_update_status(sharp_nt->backlight); | ||
123 | } | ||
124 | 121 | ||
125 | sharp_nt->enabled = false; | 122 | sharp_nt->enabled = false; |
126 | 123 | ||
@@ -203,10 +200,7 @@ static int sharp_nt_panel_enable(struct drm_panel *panel) | |||
203 | if (sharp_nt->enabled) | 200 | if (sharp_nt->enabled) |
204 | return 0; | 201 | return 0; |
205 | 202 | ||
206 | if (sharp_nt->backlight) { | 203 | backlight_enable(sharp_nt->backlight); |
207 | sharp_nt->backlight->props.power = FB_BLANK_UNBLANK; | ||
208 | backlight_update_status(sharp_nt->backlight); | ||
209 | } | ||
210 | 204 | ||
211 | sharp_nt->enabled = true; | 205 | sharp_nt->enabled = true; |
212 | 206 | ||