aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Kicinski <jakub.kicinski@netronome.com>2017-03-02 18:26:21 -0500
committerDavid S. Miller <davem@davemloft.net>2017-03-03 12:46:53 -0500
commitd58cebb79b62ff84b537a35423b8d6b7f0746985 (patch)
tree3fbcb45a062c129eca16849fb8c396401fd25cbf
parent9383b33771e566fa547daa2d09c6e0f1aaa298c3 (diff)
nfp: correct DMA direction in XDP DMA sync
dma_sync_single_for_*() takes the direction in which the buffer was mapped, not the direction of the sync. We should sync XDP buffers bidirectionally. Fixes: ecd63a0217d5 ("nfp: add XDP support in the driver") Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/netronome/nfp/nfp_net_common.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index 00a83218857a..9179a99563af 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -1498,7 +1498,7 @@ nfp_net_tx_xdp_buf(struct nfp_net *nn, struct nfp_net_rx_ring *rx_ring,
1498 txbuf->real_len = pkt_len; 1498 txbuf->real_len = pkt_len;
1499 1499
1500 dma_sync_single_for_device(&nn->pdev->dev, rxbuf->dma_addr + pkt_off, 1500 dma_sync_single_for_device(&nn->pdev->dev, rxbuf->dma_addr + pkt_off,
1501 pkt_len, DMA_TO_DEVICE); 1501 pkt_len, DMA_BIDIRECTIONAL);
1502 1502
1503 /* Build TX descriptor */ 1503 /* Build TX descriptor */
1504 txd = &tx_ring->txds[wr_idx]; 1504 txd = &tx_ring->txds[wr_idx];
@@ -1611,7 +1611,7 @@ static int nfp_net_rx(struct nfp_net_rx_ring *rx_ring, int budget)
1611 1611
1612 dma_sync_single_for_cpu(&nn->pdev->dev, 1612 dma_sync_single_for_cpu(&nn->pdev->dev,
1613 rxbuf->dma_addr + pkt_off, 1613 rxbuf->dma_addr + pkt_off,
1614 pkt_len, DMA_FROM_DEVICE); 1614 pkt_len, DMA_BIDIRECTIONAL);
1615 act = nfp_net_run_xdp(xdp_prog, rxbuf->frag + data_off, 1615 act = nfp_net_run_xdp(xdp_prog, rxbuf->frag + data_off,
1616 pkt_len); 1616 pkt_len);
1617 switch (act) { 1617 switch (act) {