Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6

Pull crypto fixes from Herbert Xu:
 "Fix two regressions in the inside-secure driver with respect to
  hmac(sha1)"

* 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6:
  crypto: inside-secure - fix the sha state length in hmac_sha1_setkey
  crypto: inside-secure - fix invalidation check in hmac_sha1_setkey

1 files changed, 4 insertions, 4 deletions

diff --git a/drivers/crypto/inside-secure/safexcel_hash.c b/drivers/crypto/inside-secure/safexcel_hash.c
index 8527a5899a2f..3f819399cd95 100644
--- a/drivers/crypto/inside-secure/safexcel_hash.c
+++ b/drivers/crypto/inside-secure/safexcel_hash.c
@@ -883,10 +883,7 @@ static int safexcel_hmac_sha1_setkey(struct crypto_ahash *tfm, const u8 *key,
         if (ret)
                 return ret;
 
-        memcpy(ctx->ipad, &istate.state, SHA1_DIGEST_SIZE);
-        memcpy(ctx->opad, &ostate.state, SHA1_DIGEST_SIZE);
-
-        for (i = 0; i < ARRAY_SIZE(istate.state); i++) {
+        for (i = 0; i < SHA1_DIGEST_SIZE / sizeof(u32); i++) {
                 if (ctx->ipad[i] != le32_to_cpu(istate.state[i]) ||
                     ctx->opad[i] != le32_to_cpu(ostate.state[i])) {
                         ctx->base.needs_inv = true;
@@ -894,6 +891,9 @@ static int safexcel_hmac_sha1_setkey(struct crypto_ahash *tfm, const u8 *key,
                 }
         }
 
+        memcpy(ctx->ipad, &istate.state, SHA1_DIGEST_SIZE);
+        memcpy(ctx->opad, &ostate.state, SHA1_DIGEST_SIZE);
+
         return 0;
 }