diff options
| author | Josh Poimboeuf <jpoimboe@redhat.com> | 2017-10-09 21:20:05 -0400 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2017-10-10 06:49:49 -0400 |
| commit | d4a2d031dd42f9594107d317e2a9a0c6d73ad46b (patch) | |
| tree | b83365c463ca1a5805632e46583a385bbc17f9e8 | |
| parent | 99bd28a49b150e4b938313a63b5532d95ba77885 (diff) | |
x86/unwind: Disable unwinder warnings on 32-bit
x86-32 doesn't have stack validation, so in most cases it doesn't make
sense to warn about bad frame pointers.
Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Byungchul Park <byungchul.park@lge.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>
Cc: LKP <lkp@01.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/a69658760800bf281e6353248c23e0fa0acf5230.1507597785.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
| -rw-r--r-- | arch/x86/kernel/unwind_frame.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/arch/x86/kernel/unwind_frame.c b/arch/x86/kernel/unwind_frame.c index 81aca077fbb6..3dc26f95d46e 100644 --- a/arch/x86/kernel/unwind_frame.c +++ b/arch/x86/kernel/unwind_frame.c | |||
| @@ -355,6 +355,13 @@ bad_address: | |||
| 355 | state->regs->sp < (unsigned long)task_pt_regs(state->task)) | 355 | state->regs->sp < (unsigned long)task_pt_regs(state->task)) |
| 356 | goto the_end; | 356 | goto the_end; |
| 357 | 357 | ||
| 358 | /* | ||
| 359 | * There are some known frame pointer issues on 32-bit. Disable | ||
| 360 | * unwinder warnings on 32-bit until it gets objtool support. | ||
| 361 | */ | ||
| 362 | if (IS_ENABLED(CONFIG_X86_32)) | ||
| 363 | goto the_end; | ||
| 364 | |||
| 358 | if (state->regs) { | 365 | if (state->regs) { |
| 359 | printk_deferred_once(KERN_WARNING | 366 | printk_deferred_once(KERN_WARNING |
| 360 | "WARNING: kernel stack regs at %p in %s:%d has bad 'bp' value %p\n", | 367 | "WARNING: kernel stack regs at %p in %s:%d has bad 'bp' value %p\n", |
