aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Weinberger <richard@nod.at>2016-09-21 05:44:41 -0400
committerBoris Brezillon <boris.brezillon@free-electrons.com>2016-09-23 03:35:16 -0400
commitd44154f969a44269a9288c274c1c2fd9e85df8a5 (patch)
treee7988379fcd6d1a917db7139f11f4bac95fc46f9
parenta9843193ce00b7f83432abe0815d03ffbeaf6ecf (diff)
mtd: nand: Provide nand_cleanup() function to free NAND related resources
Provide a nand_cleanup() function to free all nand related resources without unregistering the mtd device. This should allow drivers to call mtd_device_unregister() and handle its return value and still being able to cleanup all nand related resources. Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: Daniel Walter <dwalter@sigma-star.at> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
-rw-r--r--drivers/mtd/nand/nand_base.c22
-rw-r--r--include/linux/mtd/nand.h5
2 files changed, 19 insertions, 8 deletions
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index c06146941e16..7a00245ebada 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -4799,19 +4799,15 @@ int nand_scan(struct mtd_info *mtd, int maxchips)
4799EXPORT_SYMBOL(nand_scan); 4799EXPORT_SYMBOL(nand_scan);
4800 4800
4801/** 4801/**
4802 * nand_release - [NAND Interface] Free resources held by the NAND device 4802 * nand_cleanup - [NAND Interface] Free resources held by the NAND device
4803 * @mtd: MTD device structure 4803 * @chip: NAND chip object
4804 */ 4804 */
4805void nand_release(struct mtd_info *mtd) 4805void nand_cleanup(struct nand_chip *chip)
4806{ 4806{
4807 struct nand_chip *chip = mtd_to_nand(mtd);
4808
4809 if (chip->ecc.mode == NAND_ECC_SOFT && 4807 if (chip->ecc.mode == NAND_ECC_SOFT &&
4810 chip->ecc.algo == NAND_ECC_BCH) 4808 chip->ecc.algo == NAND_ECC_BCH)
4811 nand_bch_free((struct nand_bch_control *)chip->ecc.priv); 4809 nand_bch_free((struct nand_bch_control *)chip->ecc.priv);
4812 4810
4813 mtd_device_unregister(mtd);
4814
4815 nand_release_data_interface(chip); 4811 nand_release_data_interface(chip);
4816 4812
4817 /* Free bad block table memory */ 4813 /* Free bad block table memory */
@@ -4824,6 +4820,18 @@ void nand_release(struct mtd_info *mtd)
4824 & NAND_BBT_DYNAMICSTRUCT) 4820 & NAND_BBT_DYNAMICSTRUCT)
4825 kfree(chip->badblock_pattern); 4821 kfree(chip->badblock_pattern);
4826} 4822}
4823EXPORT_SYMBOL_GPL(nand_cleanup);
4824
4825/**
4826 * nand_release - [NAND Interface] Unregister the MTD device and free resources
4827 * held by the NAND device
4828 * @mtd: MTD device structure
4829 */
4830void nand_release(struct mtd_info *mtd)
4831{
4832 mtd_device_unregister(mtd);
4833 nand_cleanup(mtd_to_nand(mtd));
4834}
4827EXPORT_SYMBOL_GPL(nand_release); 4835EXPORT_SYMBOL_GPL(nand_release);
4828 4836
4829MODULE_LICENSE("GPL"); 4837MODULE_LICENSE("GPL");
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 331caf987b16..c5d3d5024fc8 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -38,7 +38,7 @@ int nand_scan_ident(struct mtd_info *mtd, int max_chips,
38 struct nand_flash_dev *table); 38 struct nand_flash_dev *table);
39int nand_scan_tail(struct mtd_info *mtd); 39int nand_scan_tail(struct mtd_info *mtd);
40 40
41/* Free resources held by the NAND device */ 41/* Unregister the MTD device and free resources held by the NAND device */
42void nand_release(struct mtd_info *mtd); 42void nand_release(struct mtd_info *mtd);
43 43
44/* Internal helper for board drivers which need to override command function */ 44/* Internal helper for board drivers which need to override command function */
@@ -1186,4 +1186,7 @@ int nand_read_oob_syndrome(struct mtd_info *mtd, struct nand_chip *chip,
1186/* Reset and initialize a NAND device */ 1186/* Reset and initialize a NAND device */
1187int nand_reset(struct nand_chip *chip); 1187int nand_reset(struct nand_chip *chip);
1188 1188
1189/* Free resources held by the NAND device */
1190void nand_cleanup(struct nand_chip *chip);
1191
1189#endif /* __LINUX_MTD_NAND_H */ 1192#endif /* __LINUX_MTD_NAND_H */