diff options
author | David S. Miller <davem@davemloft.net> | 2015-11-02 15:56:12 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-11-02 15:56:12 -0500 |
commit | d3e8b858f375595421817a5475611a3e63bb4a43 (patch) | |
tree | 7df2e239dd3aae3ab9e4d65dcdd00326cd97e0b5 | |
parent | 615a1003c6502f0d1812fd2dbe08e86b1c3f5db9 (diff) | |
parent | b61ed8fdd845340ee31e8a97403b6101ccf4e4a2 (diff) |
Merge branch 'sh_eth-fixes'
Sergei Shtylyov says:
====================
sh_eth: fix bugs in sh_eth_ring_init()
Here's a set of 2 patches against DaveM's 'net.git' repo which fix couple of
bugs in the sh_eth_ring_init() function.
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/renesas/sh_eth.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index a484d8beb855..459c93aff03e 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c | |||
@@ -1212,15 +1212,15 @@ static int sh_eth_ring_init(struct net_device *ndev) | |||
1212 | mdp->rx_buf_sz += NET_IP_ALIGN; | 1212 | mdp->rx_buf_sz += NET_IP_ALIGN; |
1213 | 1213 | ||
1214 | /* Allocate RX and TX skb rings */ | 1214 | /* Allocate RX and TX skb rings */ |
1215 | mdp->rx_skbuff = kmalloc_array(mdp->num_rx_ring, | 1215 | mdp->rx_skbuff = kcalloc(mdp->num_rx_ring, sizeof(*mdp->rx_skbuff), |
1216 | sizeof(*mdp->rx_skbuff), GFP_KERNEL); | 1216 | GFP_KERNEL); |
1217 | if (!mdp->rx_skbuff) { | 1217 | if (!mdp->rx_skbuff) { |
1218 | ret = -ENOMEM; | 1218 | ret = -ENOMEM; |
1219 | return ret; | 1219 | return ret; |
1220 | } | 1220 | } |
1221 | 1221 | ||
1222 | mdp->tx_skbuff = kmalloc_array(mdp->num_tx_ring, | 1222 | mdp->tx_skbuff = kcalloc(mdp->num_tx_ring, sizeof(*mdp->tx_skbuff), |
1223 | sizeof(*mdp->tx_skbuff), GFP_KERNEL); | 1223 | GFP_KERNEL); |
1224 | if (!mdp->tx_skbuff) { | 1224 | if (!mdp->tx_skbuff) { |
1225 | ret = -ENOMEM; | 1225 | ret = -ENOMEM; |
1226 | goto skb_ring_free; | 1226 | goto skb_ring_free; |
@@ -1232,7 +1232,7 @@ static int sh_eth_ring_init(struct net_device *ndev) | |||
1232 | GFP_KERNEL); | 1232 | GFP_KERNEL); |
1233 | if (!mdp->rx_ring) { | 1233 | if (!mdp->rx_ring) { |
1234 | ret = -ENOMEM; | 1234 | ret = -ENOMEM; |
1235 | goto desc_ring_free; | 1235 | goto skb_ring_free; |
1236 | } | 1236 | } |
1237 | 1237 | ||
1238 | mdp->dirty_rx = 0; | 1238 | mdp->dirty_rx = 0; |