aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Boyd <sboyd@codeaurora.org>2014-03-29 15:32:06 -0400
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2014-03-30 16:25:17 -0400
commitd3e6a67c7e502e8d21624c453f1d1f697e674548 (patch)
tree55acef7d1d65c646d47e8ef457b3dd184e9dd187
parente70f18e1c7868bebad16b21b4821b2adb8c1abf8 (diff)
Input: pmic8xxx-keypad - fix build by removing gpio configuration
The gpio configuration in this driver doesn't work because the gpio.h include doesn't exist. Remove the configuration as it isn't strictly necessary, allowing us to actually compile this driver. If it's needed in the future, it should be done via a pinctrl driver. Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r--drivers/input/keyboard/pmic8xxx-keypad.c58
1 files changed, 0 insertions, 58 deletions
diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c
index 2c9f19ac35ea..c4aa882c8fb9 100644
--- a/drivers/input/keyboard/pmic8xxx-keypad.c
+++ b/drivers/input/keyboard/pmic8xxx-keypad.c
@@ -21,7 +21,6 @@
21#include <linux/mutex.h> 21#include <linux/mutex.h>
22 22
23#include <linux/mfd/pm8xxx/core.h> 23#include <linux/mfd/pm8xxx/core.h>
24#include <linux/mfd/pm8xxx/gpio.h>
25#include <linux/input/pmic8xxx-keypad.h> 24#include <linux/input/pmic8xxx-keypad.h>
26 25
27#define PM8XXX_MAX_ROWS 18 26#define PM8XXX_MAX_ROWS 18
@@ -447,27 +446,6 @@ static int pmic8xxx_kpd_init(struct pmic8xxx_kp *kp)
447 446
448} 447}
449 448
450static int pmic8xxx_kp_config_gpio(int gpio_start, int num_gpios,
451 struct pmic8xxx_kp *kp, struct pm_gpio *gpio_config)
452{
453 int rc, i;
454
455 if (gpio_start < 0 || num_gpios < 0)
456 return -EINVAL;
457
458 for (i = 0; i < num_gpios; i++) {
459 rc = pm8xxx_gpio_config(gpio_start + i, gpio_config);
460 if (rc) {
461 dev_err(kp->dev, "%s: FAIL pm8xxx_gpio_config():"
462 "for PM GPIO [%d] rc=%d.\n",
463 __func__, gpio_start + i, rc);
464 return rc;
465 }
466 }
467
468 return 0;
469}
470
471static int pmic8xxx_kp_enable(struct pmic8xxx_kp *kp) 449static int pmic8xxx_kp_enable(struct pmic8xxx_kp *kp)
472{ 450{
473 int rc; 451 int rc;
@@ -527,27 +505,6 @@ static int pmic8xxx_kp_probe(struct platform_device *pdev)
527 int rc; 505 int rc;
528 u8 ctrl_val; 506 u8 ctrl_val;
529 507
530 struct pm_gpio kypd_drv = {
531 .direction = PM_GPIO_DIR_OUT,
532 .output_buffer = PM_GPIO_OUT_BUF_OPEN_DRAIN,
533 .output_value = 0,
534 .pull = PM_GPIO_PULL_NO,
535 .vin_sel = PM_GPIO_VIN_S3,
536 .out_strength = PM_GPIO_STRENGTH_LOW,
537 .function = PM_GPIO_FUNC_1,
538 .inv_int_pol = 1,
539 };
540
541 struct pm_gpio kypd_sns = {
542 .direction = PM_GPIO_DIR_IN,
543 .pull = PM_GPIO_PULL_UP_31P5,
544 .vin_sel = PM_GPIO_VIN_S3,
545 .out_strength = PM_GPIO_STRENGTH_NO,
546 .function = PM_GPIO_FUNC_NORMAL,
547 .inv_int_pol = 1,
548 };
549
550
551 if (!pdata || !pdata->num_cols || !pdata->num_rows || 508 if (!pdata || !pdata->num_cols || !pdata->num_rows ||
552 pdata->num_cols > PM8XXX_MAX_COLS || 509 pdata->num_cols > PM8XXX_MAX_COLS ||
553 pdata->num_rows > PM8XXX_MAX_ROWS || 510 pdata->num_rows > PM8XXX_MAX_ROWS ||
@@ -653,20 +610,6 @@ static int pmic8xxx_kp_probe(struct platform_device *pdev)
653 goto err_get_irq; 610 goto err_get_irq;
654 } 611 }
655 612
656 rc = pmic8xxx_kp_config_gpio(pdata->cols_gpio_start,
657 pdata->num_cols, kp, &kypd_sns);
658 if (rc < 0) {
659 dev_err(&pdev->dev, "unable to configure keypad sense lines\n");
660 goto err_gpio_config;
661 }
662
663 rc = pmic8xxx_kp_config_gpio(pdata->rows_gpio_start,
664 pdata->num_rows, kp, &kypd_drv);
665 if (rc < 0) {
666 dev_err(&pdev->dev, "unable to configure keypad drive lines\n");
667 goto err_gpio_config;
668 }
669
670 rc = request_any_context_irq(kp->key_sense_irq, pmic8xxx_kp_irq, 613 rc = request_any_context_irq(kp->key_sense_irq, pmic8xxx_kp_irq,
671 IRQF_TRIGGER_RISING, "pmic-keypad", kp); 614 IRQF_TRIGGER_RISING, "pmic-keypad", kp);
672 if (rc < 0) { 615 if (rc < 0) {
@@ -703,7 +646,6 @@ err_pmic_reg_read:
703 free_irq(kp->key_stuck_irq, kp); 646 free_irq(kp->key_stuck_irq, kp);
704err_req_stuck_irq: 647err_req_stuck_irq:
705 free_irq(kp->key_sense_irq, kp); 648 free_irq(kp->key_sense_irq, kp);
706err_gpio_config:
707err_get_irq: 649err_get_irq:
708 input_free_device(kp->input); 650 input_free_device(kp->input);
709err_alloc_device: 651err_alloc_device: