diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2019-02-23 08:20:41 -0500 |
|---|---|---|
| committer | Viresh Kumar <viresh.kumar@linaro.org> | 2019-02-24 23:29:15 -0500 |
| commit | d3c1e33f5c8670ca4512d17bf712ec946eab20ea (patch) | |
| tree | 14321951198a5c3d461462a77a911de5378edc7f | |
| parent | f525a670533d961fd72ab748e3aac002d7b3d1b9 (diff) | |
cpufreq: ap806: add missing of_node_put after of_device_is_available
Add an of_node_put when a tested device node is not available.
The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@
e = f(...);
... when != of_node_put(e)
when != x = e
when != e = x
when any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
// </smpl>
Fixes: f525a670533d9 ("cpufreq: ap806: add cpufreq driver for Armada 8K")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
| -rw-r--r-- | drivers/cpufreq/armada-8k-cpufreq.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/cpufreq/armada-8k-cpufreq.c b/drivers/cpufreq/armada-8k-cpufreq.c index 8a5ddb93fc58..b3f4bd647e9b 100644 --- a/drivers/cpufreq/armada-8k-cpufreq.c +++ b/drivers/cpufreq/armada-8k-cpufreq.c | |||
| @@ -128,8 +128,10 @@ static int __init armada_8k_cpufreq_init(void) | |||
| 128 | struct cpumask cpus; | 128 | struct cpumask cpus; |
| 129 | 129 | ||
| 130 | node = of_find_compatible_node(NULL, NULL, "marvell,ap806-cpu-clock"); | 130 | node = of_find_compatible_node(NULL, NULL, "marvell,ap806-cpu-clock"); |
| 131 | if (!node || !of_device_is_available(node)) | 131 | if (!node || !of_device_is_available(node)) { |
| 132 | of_node_put(node); | ||
| 132 | return -ENODEV; | 133 | return -ENODEV; |
| 134 | } | ||
| 133 | 135 | ||
| 134 | nb_cpus = num_possible_cpus(); | 136 | nb_cpus = num_possible_cpus(); |
| 135 | freq_tables = kcalloc(nb_cpus, sizeof(*freq_tables), GFP_KERNEL); | 137 | freq_tables = kcalloc(nb_cpus, sizeof(*freq_tables), GFP_KERNEL); |
