aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2018-01-04 06:25:07 -0500
committerSteffen Klassert <steffen.klassert@secunet.com>2018-01-05 03:33:14 -0500
commitd16b46e4fd8bc6063624605f25b8c0835bb1fbe3 (patch)
tree2082d0d7f510842ede6ba05a671ed7d4693b7a09
parent2f10a61cee8fdb9f8da90f5db687e1862b22cf06 (diff)
xfrm: Use __skb_queue_tail in xfrm_trans_queue
We do not need locking in xfrm_trans_queue because it is designed to use per-CPU buffers. However, the original code incorrectly used skb_queue_tail which takes the lock. This patch switches it to __skb_queue_tail instead. Reported-and-tested-by: Artem Savkov <asavkov@redhat.com> Fixes: acf568ee859f ("xfrm: Reinject transport-mode packets...") Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
-rw-r--r--net/xfrm/xfrm_input.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index 3f6f6f8c9fa5..5b2409746ae0 100644
--- a/net/xfrm/xfrm_input.c
+++ b/net/xfrm/xfrm_input.c
@@ -518,7 +518,7 @@ int xfrm_trans_queue(struct sk_buff *skb,
518 return -ENOBUFS; 518 return -ENOBUFS;
519 519
520 XFRM_TRANS_SKB_CB(skb)->finish = finish; 520 XFRM_TRANS_SKB_CB(skb)->finish = finish;
521 skb_queue_tail(&trans->queue, skb); 521 __skb_queue_tail(&trans->queue, skb);
522 tasklet_schedule(&trans->tasklet); 522 tasklet_schedule(&trans->tasklet);
523 return 0; 523 return 0;
524} 524}