aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoss Lagerwall <ross.lagerwall@citrix.com>2018-01-09 07:10:22 -0500
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>2018-01-10 08:38:44 -0500
commitcf2acf66ad43abb39735568f55e1f85f9844e990 (patch)
tree1098f9267ea80e9bcdf9367da3c7ba0dd847ae1c
parent951a010233625b77cde3430b4b8785a9a22968d1 (diff)
xen/gntdev: Fix partial gntdev_mmap() cleanup
When cleaning up after a partially successful gntdev_mmap(), unmap the successfully mapped grant pages otherwise Xen will kill the domain if in debug mode (Attempt to implicitly unmap a granted PTE) or Linux will kill the process and emit "BUG: Bad page map in process" if Xen is in release mode. This is only needed when use_ptemod is true because gntdev_put_map() will unmap grant pages itself when use_ptemod is false. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
-rw-r--r--drivers/xen/gntdev.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index d3391a1e3796..bd56653b9bbc 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -1071,8 +1071,10 @@ unlock_out:
1071out_unlock_put: 1071out_unlock_put:
1072 mutex_unlock(&priv->lock); 1072 mutex_unlock(&priv->lock);
1073out_put_map: 1073out_put_map:
1074 if (use_ptemod) 1074 if (use_ptemod) {
1075 map->vma = NULL; 1075 map->vma = NULL;
1076 unmap_grant_pages(map, 0, map->count);
1077 }
1076 gntdev_put_map(priv, map); 1078 gntdev_put_map(priv, map);
1077 return err; 1079 return err;
1078} 1080}