diff options
author | Andres Rodriguez <andresx7@gmail.com> | 2018-05-10 16:08:39 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-05-14 10:43:09 -0400 |
commit | cf1cde7cd6e42aa65aa7a80e4980afe6d1a1330e (patch) | |
tree | f7393d4d7f2db3a935a6fa4b82eb6d9617a3bb74 | |
parent | c35f9cbb1df8f17d398112173024a76964b5154d (diff) |
firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()
This is done since this call is now exposed through kernel-doc,
and since this also paves the way for different future types of
fallback mechanims.
Signed-off-by: Andres Rodriguez <andresx7@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
[mcgrof: small coding style changes]
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/base/firmware_loader/fallback.c | 8 | ||||
-rw-r--r-- | drivers/base/firmware_loader/fallback.h | 16 | ||||
-rw-r--r-- | drivers/base/firmware_loader/firmware.h | 2 | ||||
-rw-r--r-- | drivers/base/firmware_loader/main.c | 2 |
4 files changed, 14 insertions, 14 deletions
diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index 529f7013616f..3db9e0f225ac 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c | |||
@@ -662,10 +662,10 @@ static bool fw_run_sysfs_fallback(enum fw_opt opt_flags) | |||
662 | return fw_force_sysfs_fallback(opt_flags); | 662 | return fw_force_sysfs_fallback(opt_flags); |
663 | } | 663 | } |
664 | 664 | ||
665 | int fw_sysfs_fallback(struct firmware *fw, const char *name, | 665 | int firmware_fallback_sysfs(struct firmware *fw, const char *name, |
666 | struct device *device, | 666 | struct device *device, |
667 | enum fw_opt opt_flags, | 667 | enum fw_opt opt_flags, |
668 | int ret) | 668 | int ret) |
669 | { | 669 | { |
670 | if (!fw_run_sysfs_fallback(opt_flags)) | 670 | if (!fw_run_sysfs_fallback(opt_flags)) |
671 | return ret; | 671 | return ret; |
diff --git a/drivers/base/firmware_loader/fallback.h b/drivers/base/firmware_loader/fallback.h index a3b73a09db6c..21063503e4ea 100644 --- a/drivers/base/firmware_loader/fallback.h +++ b/drivers/base/firmware_loader/fallback.h | |||
@@ -31,10 +31,10 @@ struct firmware_fallback_config { | |||
31 | }; | 31 | }; |
32 | 32 | ||
33 | #ifdef CONFIG_FW_LOADER_USER_HELPER | 33 | #ifdef CONFIG_FW_LOADER_USER_HELPER |
34 | int fw_sysfs_fallback(struct firmware *fw, const char *name, | 34 | int firmware_fallback_sysfs(struct firmware *fw, const char *name, |
35 | struct device *device, | 35 | struct device *device, |
36 | enum fw_opt opt_flags, | 36 | enum fw_opt opt_flags, |
37 | int ret); | 37 | int ret); |
38 | void kill_pending_fw_fallback_reqs(bool only_kill_custom); | 38 | void kill_pending_fw_fallback_reqs(bool only_kill_custom); |
39 | 39 | ||
40 | void fw_fallback_set_cache_timeout(void); | 40 | void fw_fallback_set_cache_timeout(void); |
@@ -43,10 +43,10 @@ void fw_fallback_set_default_timeout(void); | |||
43 | int register_sysfs_loader(void); | 43 | int register_sysfs_loader(void); |
44 | void unregister_sysfs_loader(void); | 44 | void unregister_sysfs_loader(void); |
45 | #else /* CONFIG_FW_LOADER_USER_HELPER */ | 45 | #else /* CONFIG_FW_LOADER_USER_HELPER */ |
46 | static inline int fw_sysfs_fallback(struct firmware *fw, const char *name, | 46 | static inline int firmware_fallback_sysfs(struct firmware *fw, const char *name, |
47 | struct device *device, | 47 | struct device *device, |
48 | enum fw_opt opt_flags, | 48 | enum fw_opt opt_flags, |
49 | int ret) | 49 | int ret) |
50 | { | 50 | { |
51 | /* Keep carrying over the same error */ | 51 | /* Keep carrying over the same error */ |
52 | return ret; | 52 | return ret; |
diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h index 4f433b447367..4c1395f8e7ed 100644 --- a/drivers/base/firmware_loader/firmware.h +++ b/drivers/base/firmware_loader/firmware.h | |||
@@ -20,7 +20,7 @@ | |||
20 | * @FW_OPT_NOWAIT: Used to describe the firmware request is asynchronous. | 20 | * @FW_OPT_NOWAIT: Used to describe the firmware request is asynchronous. |
21 | * @FW_OPT_USERHELPER: Enable the fallback mechanism, in case the direct | 21 | * @FW_OPT_USERHELPER: Enable the fallback mechanism, in case the direct |
22 | * filesystem lookup fails at finding the firmware. For details refer to | 22 | * filesystem lookup fails at finding the firmware. For details refer to |
23 | * fw_sysfs_fallback(). | 23 | * firmware_fallback_sysfs(). |
24 | * @FW_OPT_NO_WARN: Quiet, avoid printing warning messages. | 24 | * @FW_OPT_NO_WARN: Quiet, avoid printing warning messages. |
25 | * @FW_OPT_NOCACHE: Disables firmware caching. Firmware caching is used to | 25 | * @FW_OPT_NOCACHE: Disables firmware caching. Firmware caching is used to |
26 | * cache the firmware upon suspend, so that upon resume races against the | 26 | * cache the firmware upon suspend, so that upon resume races against the |
diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c index 4d11efadb3a4..abdc4e4d55f1 100644 --- a/drivers/base/firmware_loader/main.c +++ b/drivers/base/firmware_loader/main.c | |||
@@ -581,7 +581,7 @@ _request_firmware(const struct firmware **firmware_p, const char *name, | |||
581 | dev_warn(device, | 581 | dev_warn(device, |
582 | "Direct firmware load for %s failed with error %d\n", | 582 | "Direct firmware load for %s failed with error %d\n", |
583 | name, ret); | 583 | name, ret); |
584 | ret = fw_sysfs_fallback(fw, name, device, opt_flags, ret); | 584 | ret = firmware_fallback_sysfs(fw, name, device, opt_flags, ret); |
585 | } else | 585 | } else |
586 | ret = assign_fw(fw, device, opt_flags); | 586 | ret = assign_fw(fw, device, opt_flags); |
587 | 587 | ||