aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>2016-04-07 07:16:04 -0400
committerMarcel Holtmann <marcel@holtmann.org>2016-04-08 13:33:30 -0400
commitcd9d7213d5f546d9c0795fdcffe4ce5bf63445fd (patch)
tree5b0130f879cdde39c43c51636804b418a249eeec
parentfeb2add3235ca81dc5cd5d975490c707a24c9889 (diff)
ieee802154/adf7242: fix memory leak of firmware
If the firmware upload or the firmware verification fails then we printed the error message and exited but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
-rw-r--r--drivers/net/ieee802154/adf7242.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
index 89154c079788..b82e39d24394 100644
--- a/drivers/net/ieee802154/adf7242.c
+++ b/drivers/net/ieee802154/adf7242.c
@@ -1030,6 +1030,7 @@ static int adf7242_hw_init(struct adf7242_local *lp)
1030 if (ret) { 1030 if (ret) {
1031 dev_err(&lp->spi->dev, 1031 dev_err(&lp->spi->dev,
1032 "upload firmware failed with %d\n", ret); 1032 "upload firmware failed with %d\n", ret);
1033 release_firmware(fw);
1033 return ret; 1034 return ret;
1034 } 1035 }
1035 1036
@@ -1037,6 +1038,7 @@ static int adf7242_hw_init(struct adf7242_local *lp)
1037 if (ret) { 1038 if (ret) {
1038 dev_err(&lp->spi->dev, 1039 dev_err(&lp->spi->dev,
1039 "verify firmware failed with %d\n", ret); 1040 "verify firmware failed with %d\n", ret);
1041 release_firmware(fw);
1040 return ret; 1042 return ret;
1041 } 1043 }
1042 1044