diff options
author | Olof Johansson <olof@lixom.net> | 2017-06-18 21:55:59 -0400 |
---|---|---|
committer | Olof Johansson <olof@lixom.net> | 2017-06-18 21:55:59 -0400 |
commit | cd8eb6291d5323477c342778548e262e8c97cef2 (patch) | |
tree | 15966e5e534b63ea18ea67fcb696c9fb02ff5a87 | |
parent | 5ed02dbb497422bf225783f46e6eadd237d23d6b (diff) | |
parent | c9eabf40d91b4fe954efe380d88590d933baa06d (diff) |
Merge tag 'omap-for-v4.13/gpmc-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into next/drivers
Few improvments for GPMC (General Purpose Memory Controller)
found on TI SoCs to produce an error for missing bank-width
and to make the bootloader timing debug output usable for
device tree timings.
* tag 'omap-for-v4.13/gpmc-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap:
memory: omap-gpmc: add error message if bank-width property is absent
memory: omap-gpmc: make dts snippet include semicolon
Signed-off-by: Olof Johansson <olof@lixom.net>
-rw-r--r-- | drivers/memory/omap-gpmc.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 6d1b4b707cc2..a80e17de906d 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c | |||
@@ -460,12 +460,12 @@ static int get_gpmc_timing_reg( | |||
460 | if (l) | 460 | if (l) |
461 | time_ns_min = gpmc_clk_ticks_to_ns(l - 1, cs, cd) + 1; | 461 | time_ns_min = gpmc_clk_ticks_to_ns(l - 1, cs, cd) + 1; |
462 | time_ns = gpmc_clk_ticks_to_ns(l, cs, cd); | 462 | time_ns = gpmc_clk_ticks_to_ns(l, cs, cd); |
463 | pr_info("gpmc,%s = <%u> /* %u ns - %u ns; %i ticks%s*/\n", | 463 | pr_info("gpmc,%s = <%u>; /* %u ns - %u ns; %i ticks%s*/\n", |
464 | name, time_ns, time_ns_min, time_ns, l, | 464 | name, time_ns, time_ns_min, time_ns, l, |
465 | invalid ? "; invalid " : " "); | 465 | invalid ? "; invalid " : " "); |
466 | } else { | 466 | } else { |
467 | /* raw format */ | 467 | /* raw format */ |
468 | pr_info("gpmc,%s = <%u>%s\n", name, l, | 468 | pr_info("gpmc,%s = <%u>;%s\n", name, l, |
469 | invalid ? " /* invalid */" : ""); | 469 | invalid ? " /* invalid */" : ""); |
470 | } | 470 | } |
471 | 471 | ||
@@ -2083,8 +2083,11 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, | |||
2083 | } else { | 2083 | } else { |
2084 | ret = of_property_read_u32(child, "bank-width", | 2084 | ret = of_property_read_u32(child, "bank-width", |
2085 | &gpmc_s.device_width); | 2085 | &gpmc_s.device_width); |
2086 | if (ret < 0) | 2086 | if (ret < 0) { |
2087 | dev_err(&pdev->dev, "%s has no 'bank-width' property\n", | ||
2088 | child->full_name); | ||
2087 | goto err; | 2089 | goto err; |
2090 | } | ||
2088 | } | 2091 | } |
2089 | 2092 | ||
2090 | /* Reserve wait pin if it is required and valid */ | 2093 | /* Reserve wait pin if it is required and valid */ |