diff options
author | Masami Hiramatsu <mhiramat@kernel.org> | 2017-09-19 05:59:39 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2017-09-28 03:23:03 -0400 |
commit | cd52edad55fbcd8064877a77d31445b2fb4b85c3 (patch) | |
tree | 5d27bbddf52356a31e32bd0ccb19a03442707a24 | |
parent | 3539d09154e11336c31a900a9cd49e386ba6d9b2 (diff) |
kprobes/x86: Move the get_kprobe_ctlblk() into irq-disabled block
Since get_kprobe_ctlblk() accesses per-cpu variables
which calls smp_processor_id(), it must be called under
preempt-disabled or irq-disabled.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alexei Starovoitov <ast@fb.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E . McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/150581517952.32348.2655896843219158446.stgit@devbox
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | arch/x86/kernel/kprobes/opt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c index 0cae7c0f32ec..f55810305f9a 100644 --- a/arch/x86/kernel/kprobes/opt.c +++ b/arch/x86/kernel/kprobes/opt.c | |||
@@ -154,7 +154,6 @@ STACK_FRAME_NON_STANDARD(optprobe_template_func); | |||
154 | static void | 154 | static void |
155 | optimized_callback(struct optimized_kprobe *op, struct pt_regs *regs) | 155 | optimized_callback(struct optimized_kprobe *op, struct pt_regs *regs) |
156 | { | 156 | { |
157 | struct kprobe_ctlblk *kcb = get_kprobe_ctlblk(); | ||
158 | unsigned long flags; | 157 | unsigned long flags; |
159 | 158 | ||
160 | /* This is possible if op is under delayed unoptimizing */ | 159 | /* This is possible if op is under delayed unoptimizing */ |
@@ -165,6 +164,7 @@ optimized_callback(struct optimized_kprobe *op, struct pt_regs *regs) | |||
165 | if (kprobe_running()) { | 164 | if (kprobe_running()) { |
166 | kprobes_inc_nmissed_count(&op->kp); | 165 | kprobes_inc_nmissed_count(&op->kp); |
167 | } else { | 166 | } else { |
167 | struct kprobe_ctlblk *kcb = get_kprobe_ctlblk(); | ||
168 | /* Save skipped registers */ | 168 | /* Save skipped registers */ |
169 | #ifdef CONFIG_X86_64 | 169 | #ifdef CONFIG_X86_64 |
170 | regs->cs = __KERNEL_CS; | 170 | regs->cs = __KERNEL_CS; |