diff options
author | Maarten Lankhorst <maarten.lankhorst@linux.intel.com> | 2018-04-09 08:46:53 -0400 |
---|---|---|
committer | Maarten Lankhorst <maarten.lankhorst@linux.intel.com> | 2018-04-09 09:58:53 -0400 |
commit | cd27d88fba98660da870c00eda5ac0ea7969fc8e (patch) | |
tree | 50fcbcfd95f9e28d8564970a356893237466dee3 | |
parent | 0c5c7df360dbcfefac61ebd118c8551acf714d79 (diff) |
drm/i915: Change use get_new_plane_state instead of existing plane state
The get_existing macros are deprecated and should be replaced by
get_old/new_state for clarity.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180409124656.39886-1-maarten.lankhorst@linux.intel.com
[mlankhorst: Remove useless warn. (Ville)]
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
-rw-r--r-- | drivers/gpu/drm/i915/intel_atomic.c | 5 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_drv.h | 11 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_pm.c | 2 |
3 files changed, 3 insertions, 15 deletions
diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_atomic.c index bb8c1687823e..40285d1b91b7 100644 --- a/drivers/gpu/drm/i915/intel_atomic.c +++ b/drivers/gpu/drm/i915/intel_atomic.c | |||
@@ -227,6 +227,7 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, | |||
227 | struct intel_crtc_scaler_state *scaler_state = | 227 | struct intel_crtc_scaler_state *scaler_state = |
228 | &crtc_state->scaler_state; | 228 | &crtc_state->scaler_state; |
229 | struct drm_atomic_state *drm_state = crtc_state->base.state; | 229 | struct drm_atomic_state *drm_state = crtc_state->base.state; |
230 | struct intel_atomic_state *intel_state = to_intel_atomic_state(drm_state); | ||
230 | int num_scalers_need; | 231 | int num_scalers_need; |
231 | int i, j; | 232 | int i, j; |
232 | 233 | ||
@@ -304,8 +305,8 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, | |||
304 | continue; | 305 | continue; |
305 | } | 306 | } |
306 | 307 | ||
307 | plane_state = intel_atomic_get_existing_plane_state(drm_state, | 308 | plane_state = intel_atomic_get_new_plane_state(intel_state, |
308 | intel_plane); | 309 | intel_plane); |
309 | scaler_id = &plane_state->scaler_id; | 310 | scaler_id = &plane_state->scaler_id; |
310 | } | 311 | } |
311 | 312 | ||
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index b2e0fa04ef5b..e545aa673bd9 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h | |||
@@ -2109,17 +2109,6 @@ intel_atomic_get_existing_crtc_state(struct drm_atomic_state *state, | |||
2109 | return NULL; | 2109 | return NULL; |
2110 | } | 2110 | } |
2111 | 2111 | ||
2112 | static inline struct intel_plane_state * | ||
2113 | intel_atomic_get_existing_plane_state(struct drm_atomic_state *state, | ||
2114 | struct intel_plane *plane) | ||
2115 | { | ||
2116 | struct drm_plane_state *plane_state; | ||
2117 | |||
2118 | plane_state = drm_atomic_get_existing_plane_state(state, &plane->base); | ||
2119 | |||
2120 | return to_intel_plane_state(plane_state); | ||
2121 | } | ||
2122 | |||
2123 | int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, | 2112 | int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv, |
2124 | struct intel_crtc *intel_crtc, | 2113 | struct intel_crtc *intel_crtc, |
2125 | struct intel_crtc_state *crtc_state); | 2114 | struct intel_crtc_state *crtc_state); |
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 007a12ebe725..4baab858e442 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c | |||
@@ -5037,8 +5037,6 @@ skl_ddb_add_affected_planes(struct intel_crtc_state *cstate) | |||
5037 | struct drm_plane *plane; | 5037 | struct drm_plane *plane; |
5038 | enum pipe pipe = intel_crtc->pipe; | 5038 | enum pipe pipe = intel_crtc->pipe; |
5039 | 5039 | ||
5040 | WARN_ON(!drm_atomic_get_existing_crtc_state(state, crtc)); | ||
5041 | |||
5042 | drm_for_each_plane_mask(plane, dev, cstate->base.plane_mask) { | 5040 | drm_for_each_plane_mask(plane, dev, cstate->base.plane_mask) { |
5043 | enum plane_id plane_id = to_intel_plane(plane)->id; | 5041 | enum plane_id plane_id = to_intel_plane(plane)->id; |
5044 | 5042 | ||