diff options
author | Aurelien Jarno <aurelien@aurel32.net> | 2018-12-06 14:05:34 -0500 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2019-02-16 10:21:52 -0500 |
commit | cc4b1242d7e3b42eed73881fc749944146493e4f (patch) | |
tree | 4dbcec31cc2b4c1cda7ef42acebd3e992131bf54 | |
parent | 01e7187b41191376cee8bea8de9f907b001e87b4 (diff) |
vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1
The preadv2 and pwritev2 syscalls are supposed to emulate the readv and
writev syscalls when offset == -1. Therefore the compat code should
check for offset before calling do_compat_preadv64 and
do_compat_pwritev64. This is the case for the preadv2 and pwritev2
syscalls, but handling of offset == -1 is missing in their 64-bit
equivalent.
This patch fixes that, calling do_compat_readv and do_compat_writev when
offset == -1. This fixes the following glibc tests on x32:
- misc/tst-preadvwritev2
- misc/tst-preadvwritev64v2
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: H.J. Lu <hjl.tools@gmail.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r-- | fs/read_write.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/read_write.c b/fs/read_write.c index ff3c5e6f87cf..27b69b85d49f 100644 --- a/fs/read_write.c +++ b/fs/read_write.c | |||
@@ -1238,6 +1238,9 @@ COMPAT_SYSCALL_DEFINE5(preadv64v2, unsigned long, fd, | |||
1238 | const struct compat_iovec __user *,vec, | 1238 | const struct compat_iovec __user *,vec, |
1239 | unsigned long, vlen, loff_t, pos, rwf_t, flags) | 1239 | unsigned long, vlen, loff_t, pos, rwf_t, flags) |
1240 | { | 1240 | { |
1241 | if (pos == -1) | ||
1242 | return do_compat_readv(fd, vec, vlen, flags); | ||
1243 | |||
1241 | return do_compat_preadv64(fd, vec, vlen, pos, flags); | 1244 | return do_compat_preadv64(fd, vec, vlen, pos, flags); |
1242 | } | 1245 | } |
1243 | #endif | 1246 | #endif |
@@ -1344,6 +1347,9 @@ COMPAT_SYSCALL_DEFINE5(pwritev64v2, unsigned long, fd, | |||
1344 | const struct compat_iovec __user *,vec, | 1347 | const struct compat_iovec __user *,vec, |
1345 | unsigned long, vlen, loff_t, pos, rwf_t, flags) | 1348 | unsigned long, vlen, loff_t, pos, rwf_t, flags) |
1346 | { | 1349 | { |
1350 | if (pos == -1) | ||
1351 | return do_compat_writev(fd, vec, vlen, flags); | ||
1352 | |||
1347 | return do_compat_pwritev64(fd, vec, vlen, pos, flags); | 1353 | return do_compat_pwritev64(fd, vec, vlen, pos, flags); |
1348 | } | 1354 | } |
1349 | #endif | 1355 | #endif |