diff options
author | Johan Hovold <johan@kernel.org> | 2017-03-16 14:41:55 -0400 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2017-03-16 16:56:53 -0400 |
commit | cb1b494663e037253337623bf1ef2df727883cb7 (patch) | |
tree | 4ce7f194f1357eb9a8f577a9e599f31fc22f2c7f | |
parent | ba340d7b83703768ce566f53f857543359aa1b98 (diff) |
Input: kbtab - validate number of endpoints before using them
Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.
Signed-off-by: Johan Hovold <johan@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r-- | drivers/input/tablet/kbtab.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/input/tablet/kbtab.c b/drivers/input/tablet/kbtab.c index e850d7e8afbc..4d9d64908b59 100644 --- a/drivers/input/tablet/kbtab.c +++ b/drivers/input/tablet/kbtab.c | |||
@@ -122,6 +122,9 @@ static int kbtab_probe(struct usb_interface *intf, const struct usb_device_id *i | |||
122 | struct input_dev *input_dev; | 122 | struct input_dev *input_dev; |
123 | int error = -ENOMEM; | 123 | int error = -ENOMEM; |
124 | 124 | ||
125 | if (intf->cur_altsetting->desc.bNumEndpoints < 1) | ||
126 | return -ENODEV; | ||
127 | |||
125 | kbtab = kzalloc(sizeof(struct kbtab), GFP_KERNEL); | 128 | kbtab = kzalloc(sizeof(struct kbtab), GFP_KERNEL); |
126 | input_dev = input_allocate_device(); | 129 | input_dev = input_allocate_device(); |
127 | if (!kbtab || !input_dev) | 130 | if (!kbtab || !input_dev) |