aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCameron Gutman <aicommander@gmail.com>2016-06-29 12:51:35 -0400
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2016-06-29 13:07:47 -0400
commitcaca925fca4fb30c67be88cacbe908eec6721e43 (patch)
treef3a0cee72b30fdb96e316f39b42516481eb399b6
parent9a9b6aa6a8759c83024627d681eff982d6ee03b7 (diff)
Input: xpad - validate USB endpoint count during probe
This prevents a malicious USB device from causing an oops. Signed-off-by: Cameron Gutman <aicommander@gmail.com> Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r--drivers/input/joystick/xpad.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 3438e98c145a..a529a4535457 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -1431,6 +1431,9 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
1431 int ep_irq_in_idx; 1431 int ep_irq_in_idx;
1432 int i, error; 1432 int i, error;
1433 1433
1434 if (intf->cur_altsetting->desc.bNumEndpoints != 2)
1435 return -ENODEV;
1436
1434 for (i = 0; xpad_device[i].idVendor; i++) { 1437 for (i = 0; xpad_device[i].idVendor; i++) {
1435 if ((le16_to_cpu(udev->descriptor.idVendor) == xpad_device[i].idVendor) && 1438 if ((le16_to_cpu(udev->descriptor.idVendor) == xpad_device[i].idVendor) &&
1436 (le16_to_cpu(udev->descriptor.idProduct) == xpad_device[i].idProduct)) 1439 (le16_to_cpu(udev->descriptor.idProduct) == xpad_device[i].idProduct))