diff options
author | Mika Kuoppala <mika.kuoppala@intel.com> | 2015-08-11 10:44:31 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-08-14 11:50:42 -0400 |
commit | ca5a0fbd53be86d2bf44769741e02e66feeacc0a (patch) | |
tree | b0b037b44ae6323c8f0cf6e28627803d05fcb784 | |
parent | 37876df61f279099334e0108bac9d28ee9789052 (diff) |
drm/i915: Contain the WA_REG macro
Prevent leaking the if scoping by containing the WA_REG
macro inside its own scope.
Reported-by: Arun Siluvery <arun.siluvery@linux.intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
[danvet: Appease checkpatch.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r-- | drivers/gpu/drm/i915/intel_ringbuffer.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 1a10358d4c48..6e6b8db996ef 100644 --- a/drivers/gpu/drm/i915/intel_ringbuffer.c +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c | |||
@@ -780,11 +780,11 @@ static int wa_add(struct drm_i915_private *dev_priv, | |||
780 | return 0; | 780 | return 0; |
781 | } | 781 | } |
782 | 782 | ||
783 | #define WA_REG(addr, mask, val) { \ | 783 | #define WA_REG(addr, mask, val) do { \ |
784 | const int r = wa_add(dev_priv, (addr), (mask), (val)); \ | 784 | const int r = wa_add(dev_priv, (addr), (mask), (val)); \ |
785 | if (r) \ | 785 | if (r) \ |
786 | return r; \ | 786 | return r; \ |
787 | } | 787 | } while (0) |
788 | 788 | ||
789 | #define WA_SET_BIT_MASKED(addr, mask) \ | 789 | #define WA_SET_BIT_MASKED(addr, mask) \ |
790 | WA_REG(addr, (mask), _MASKED_BIT_ENABLE(mask)) | 790 | WA_REG(addr, (mask), _MASKED_BIT_ENABLE(mask)) |