diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-06-17 23:43:29 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-06-18 13:50:08 -0400 |
| commit | c92834c19fc63f8a1d344eee0dd3d62c7b449e26 (patch) | |
| tree | cb5ef707a5369595e435e717ac9bd46f9fbb1be4 | |
| parent | 2a98dbbcd72cfae508c4d90bcbdc829363554ea7 (diff) | |
usb: gadget: f_ncm: fix missing unlock on error in ncm_alloc()
Add the missing unlock before return from function ncm_alloc()
in the error handling case.
Introduced by commit e730660378be92b83288b59b824ccdace5cd2652.
(usb: gadget: f_ncm: add configfs support)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/gadget/f_ncm.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c index 47a5724211cd..952177f7eb9b 100644 --- a/drivers/usb/gadget/f_ncm.c +++ b/drivers/usb/gadget/f_ncm.c | |||
| @@ -1403,6 +1403,7 @@ struct usb_function *ncm_alloc(struct usb_function_instance *fi) | |||
| 1403 | sizeof(ncm->ethaddr)); | 1403 | sizeof(ncm->ethaddr)); |
| 1404 | if (status < 12) { /* strlen("01234567890a") */ | 1404 | if (status < 12) { /* strlen("01234567890a") */ |
| 1405 | kfree(ncm); | 1405 | kfree(ncm); |
| 1406 | mutex_unlock(&opts->lock); | ||
| 1406 | return ERR_PTR(-EINVAL); | 1407 | return ERR_PTR(-EINVAL); |
| 1407 | } | 1408 | } |
| 1408 | ncm_string_defs[STRING_MAC_IDX].s = ncm->ethaddr; | 1409 | ncm_string_defs[STRING_MAC_IDX].s = ncm->ethaddr; |