aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMauro Carvalho Chehab <mchehab@s-opensource.com>2016-10-18 15:44:18 -0400
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2016-10-21 07:52:08 -0400
commitc91e42f5efea7f2828d6f24165ada97f65f9e7e5 (patch)
tree56b525e169ae7e1d7b2bf028c4e762456ef0f0c6
parent96292c89cf1fa700ba086fd7c0e431ac90adba10 (diff)
[media] pwc: don't break long lines
Due to the 80-cols restrictions, and latter due to checkpatch warnings, several strings were broken into multiple lines. This is not considered a good practice anymore, as it makes harder to grep for strings at the source code. As we're right now fixing other drivers due to KERN_CONT, we need to be able to identify what printk strings don't end with a "\n". It is a way easier to detect those if we don't break long lines. So, join those continuation lines. The patch was generated via the script below, and manually adjusted if needed. </script> use Text::Tabs; while (<>) { if ($next ne "") { $c=$_; if ($c =~ /^\s+\"(.*)/) { $c2=$1; $next =~ s/\"\n$//; $n = expand($next); $funpos = index($n, '('); $pos = index($c2, '",'); if ($funpos && $pos > 0) { $s1 = substr $c2, 0, $pos + 2; $s2 = ' ' x ($funpos + 1) . substr $c2, $pos + 2; $s2 =~ s/^\s+//; $s2 = ' ' x ($funpos + 1) . $s2 if ($s2 ne ""); print unexpand("$next$s1\n"); print unexpand("$s2\n") if ($s2 ne ""); } else { print "$next$c2\n"; } $next=""; next; } else { print $next; } $next=""; } else { if (m/\"$/) { if (!m/\\n\"$/) { $next=$_; next; } } } print $_; } </script> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
-rw-r--r--drivers/media/usb/pwc/pwc-if.c4
-rw-r--r--drivers/media/usb/pwc/pwc-v4l.c6
2 files changed, 4 insertions, 6 deletions
diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c
index ff657644b6b3..22420c14ac98 100644
--- a/drivers/media/usb/pwc/pwc-if.c
+++ b/drivers/media/usb/pwc/pwc-if.c
@@ -238,8 +238,8 @@ static void pwc_frame_complete(struct pwc_device *pdev)
238 } else { 238 } else {
239 /* Check for underflow first */ 239 /* Check for underflow first */
240 if (fbuf->filled < pdev->frame_total_size) { 240 if (fbuf->filled < pdev->frame_total_size) {
241 PWC_DEBUG_FLOW("Frame buffer underflow (%d bytes);" 241 PWC_DEBUG_FLOW("Frame buffer underflow (%d bytes); discarded.\n",
242 " discarded.\n", fbuf->filled); 242 fbuf->filled);
243 } else { 243 } else {
244 fbuf->vb.field = V4L2_FIELD_NONE; 244 fbuf->vb.field = V4L2_FIELD_NONE;
245 fbuf->vb.sequence = pdev->vframe_count; 245 fbuf->vb.sequence = pdev->vframe_count;
diff --git a/drivers/media/usb/pwc/pwc-v4l.c b/drivers/media/usb/pwc/pwc-v4l.c
index 3d987984602f..92f04db6bbae 100644
--- a/drivers/media/usb/pwc/pwc-v4l.c
+++ b/drivers/media/usb/pwc/pwc-v4l.c
@@ -406,8 +406,7 @@ static void pwc_vidioc_fill_fmt(struct v4l2_format *f,
406 f->fmt.pix.bytesperline = f->fmt.pix.width; 406 f->fmt.pix.bytesperline = f->fmt.pix.width;
407 f->fmt.pix.sizeimage = f->fmt.pix.height * f->fmt.pix.width * 3 / 2; 407 f->fmt.pix.sizeimage = f->fmt.pix.height * f->fmt.pix.width * 3 / 2;
408 f->fmt.pix.colorspace = V4L2_COLORSPACE_SRGB; 408 f->fmt.pix.colorspace = V4L2_COLORSPACE_SRGB;
409 PWC_DEBUG_IOCTL("pwc_vidioc_fill_fmt() " 409 PWC_DEBUG_IOCTL("pwc_vidioc_fill_fmt() width=%d, height=%d, bytesperline=%d, sizeimage=%d, pixelformat=%c%c%c%c\n",
410 "width=%d, height=%d, bytesperline=%d, sizeimage=%d, pixelformat=%c%c%c%c\n",
411 f->fmt.pix.width, 410 f->fmt.pix.width,
412 f->fmt.pix.height, 411 f->fmt.pix.height,
413 f->fmt.pix.bytesperline, 412 f->fmt.pix.bytesperline,
@@ -473,8 +472,7 @@ static int pwc_s_fmt_vid_cap(struct file *file, void *fh, struct v4l2_format *f)
473 472
474 pixelformat = f->fmt.pix.pixelformat; 473 pixelformat = f->fmt.pix.pixelformat;
475 474
476 PWC_DEBUG_IOCTL("Trying to set format to: width=%d height=%d fps=%d " 475 PWC_DEBUG_IOCTL("Trying to set format to: width=%d height=%d fps=%d format=%c%c%c%c\n",
477 "format=%c%c%c%c\n",
478 f->fmt.pix.width, f->fmt.pix.height, pdev->vframes, 476 f->fmt.pix.width, f->fmt.pix.height, pdev->vframes,
479 (pixelformat)&255, 477 (pixelformat)&255,
480 (pixelformat>>8)&255, 478 (pixelformat>>8)&255,